Inna/CypherCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Core/Misc: Always reward all necessary reputations on creature kill

Browse Source 
Port From (https://github.com/TrinityCore/TrinityCore/commit/e36497aef57899f18e0d55c0640bfd96e2251a8e)
This commit is contained in:
hondacrx
2020-05-06 18:00:59 -04:00
parent f723336c35
commit 03cb874825
2 changed files with 20 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/Game/Reputation/ReputationManager.cs
+14 -3
View File
@@ -264,9 +264,17 @@ namespace Game
}
}
public bool ModifyReputation(FactionRecord factionEntry, int standing, bool noSpillover = false) { return SetReputation(factionEntry, standing, true, noSpillover); }
public bool ModifyReputation(FactionRecord factionEntry, int standing, bool spillOverOnly = false, bool noSpillover = false)
{
return SetReputation(factionEntry, standing, true, spillOverOnly, noSpillover);
}
public bool SetReputation(FactionRecord factionEntry, int standing, bool incremental = false, bool noSpillover = false)
public bool SetReputation(FactionRecord factionEntry, int standing)
{
return SetReputation(factionEntry, standing, false, false, false);
}
public bool SetReputation(FactionRecord factionEntry, int standing, bool incremental, bool spillOverOnly, bool noSpillover)
{
Global.ScriptMgr.OnPlayerReputationChange(_player, factionEntry.Id, standing, incremental);
bool res = false;
@@ -336,7 +344,10 @@ namespace Game
var faction = _factions.LookupByKey(factionEntry.ReputationIndex);
if (faction != null)
{
res = SetOneFactionReputation(factionEntry, standing, incremental);
// if we update spillover only, do not update main reputation (rank exceeds creature reward rate)
if (!spillOverOnly)
res = SetOneFactionReputation(factionEntry, standing, incremental);
// only this faction gets reported to client, even if it has no own visible standing
SendState(faction);
}