Core/Players: Fixed trait config validation

Port From (https://github.com/TrinityCore/TrinityCore/commit/1f0a62bde5b927392a58e95a87d4d8bd93438d7e)
2024-10-09 00:42:58 -04:00
parent fbe4130a54
commit 0fd399e92e
4 changed files with 78 additions and 39 deletions
@@ -2773,7 +2773,7 @@ namespace Game.Entities
            if (traitDefinitionId.HasValue)
            {
                TraitDefinitionRecord traitDefinition = CliDB.TraitDefinitionStorage.LookupByKey(traitDefinitionId.Value);
-                if (traitDefinition != null)
+                if (traitDefinition != null && traitDefinition.OverridesSpellID != 0)
                    AddOverrideSpell(traitDefinition.OverridesSpellID, spellId);
            }

@@ -1058,8 +1058,7 @@ namespace Game.Entities
            if (consumeCurrencies)
            {
                Dictionary<int, int> currencies = new();
-                foreach (TraitEntryPacket costEntry in costEntries)
-                    TraitMgr.FillSpentCurrenciesMap(costEntry, currencies);
+                TraitMgr.FillSpentCurrenciesMap(costEntries, currencies);

                foreach (var (traitCurrencyId, amount) in currencies)
                {