From 141ed88de0aa3fd2b0ed5fb68d65fdcc5885f7c5 Mon Sep 17 00:00:00 2001 From: hondacrx Date: Tue, 2 May 2023 17:25:05 -0400 Subject: [PATCH] Core/Auras: Removed outdated aura type handling Port From (https://github.com/TrinityCore/TrinityCore/commit/c563d52c8da02c610266b0376ef70ea92d022835) --- Source/Framework/Constants/Spells/SpellAuraConst.cs | 2 +- Source/Game/Entities/StatSystem.cs | 4 +--- Source/Game/Spells/SpellInfo.cs | 1 - 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/Source/Framework/Constants/Spells/SpellAuraConst.cs b/Source/Framework/Constants/Spells/SpellAuraConst.cs index 7ddc82d22..0795f4722 100644 --- a/Source/Framework/Constants/Spells/SpellAuraConst.cs +++ b/Source/Framework/Constants/Spells/SpellAuraConst.cs @@ -195,7 +195,7 @@ namespace Framework.Constants ModAttackerRangedHitChance = 185, ModAttackerSpellHitChance = 186, ModAttackerMeleeCritChance = 187, - ModAttackerRangedCritChance = 188, + ModUIHealingRange = 188, ModRating = 189, ModFactionReputationGain = 190, UseNormalMovementSpeed = 191, diff --git a/Source/Game/Entities/StatSystem.cs b/Source/Game/Entities/StatSystem.cs index b952b3c49..d1da8dcdc 100644 --- a/Source/Game/Entities/StatSystem.cs +++ b/Source/Game/Entities/StatSystem.cs @@ -852,9 +852,7 @@ namespace Game.Entities float chance = critDone; // flat aura mods - if (attackType == WeaponAttackType.RangedAttack) - chance += GetTotalAuraModifier(AuraType.ModAttackerRangedCritChance); - else + if (attackType != WeaponAttackType.RangedAttack) chance += GetTotalAuraModifier(AuraType.ModAttackerMeleeCritChance); chance += GetTotalAuraModifier(AuraType.ModCritChanceVersusTargetHealth, aurEff => !HealthBelowPct(aurEff.GetMiscValueB())); diff --git a/Source/Game/Spells/SpellInfo.cs b/Source/Game/Spells/SpellInfo.cs index a6b6749c6..e5c1b03f6 100644 --- a/Source/Game/Spells/SpellInfo.cs +++ b/Source/Game/Spells/SpellInfo.cs @@ -3661,7 +3661,6 @@ namespace Game.Spells case AuraType.ModAttackerRangedHitChance: case AuraType.ModAttackerSpellHitChance: case AuraType.ModAttackerMeleeCritChance: - case AuraType.ModAttackerRangedCritChance: case AuraType.ModAttackerSpellAndWeaponCritChance: case AuraType.Dummy: case AuraType.PeriodicDummy: