Core/Pet: Fix an issue that was causing lower ranks of pet spells to remain in DB

Port From (https://github.com/TrinityCore/TrinityCore/commit/5e3170d58e82693e7ceb29d4d9c5346906bdd98b)
2020-08-24 11:18:57 -04:00
parent 7cf9b6183e
commit 1b33551fab
1 changed files with 14 additions and 16 deletions
@@ -1028,11 +1028,10 @@ namespace Game.Entities
            if (petSpell != null)
            {
                if (petSpell.state == PetSpellState.Removed)
-                {
-                    m_spells.Remove(spellId);
                    state = PetSpellState.Changed;
-                }
-                else if (state == PetSpellState.Unchanged && petSpell.state != PetSpellState.Unchanged)
+                else
+                {
+                    if (state == PetSpellState.Unchanged && petSpell.state != PetSpellState.Unchanged)
                    {
                        // can be in case spell loading but learned at some previous spell loading
                        petSpell.state = PetSpellState.Unchanged;
@@ -1044,8 +1043,7 @@ namespace Game.Entities

                        return false;
                    }
-                else
-                    return false;
+                }
            }

            PetSpell newspell = new PetSpell();