Core/Refactor: Part 1

Source/Framework/Constants/AchievementConst.cs

@@ -13,7 +13,9 @@
  *
  * You should have received a copy of the GNU General Public License
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- */
+ */
+
+using System;
 
 namespace Framework.Constants
 {
@@ -46,6 +48,7 @@ namespace Framework.Constants
         SumChildrenWeight = 9
     }
 
+    [Flags]
     public enum AchievementFlags
     {
         Counter = 0x01,
@@ -71,6 +74,7 @@ namespace Framework.Constants
         TrackingFlag = 0x00100000
     }
 
+    [Flags]
     public enum CriteriaFlagsCu
     {
         Player = 0x1,

Source/Framework/Constants/CliDBConst.cs

@@ -849,7 +849,7 @@ namespace Framework.Constants
         FlyWarriorChargeEnd = 821
     }
 
-    public enum AreaFlags : int
+    public enum AreaFlags
     {
         Snow = 0x01,                // Snow (Only Dun Morogh, Naxxramas, Razorfen Downs And Winterspring)
         Unk1 = 0x02,                // Razorfen Downs, Naxxramas And Acherus: The Ebon Hold (3.3.5a)

Source/Framework/Constants/GuildConst.cs

@@ -191,7 +191,7 @@ namespace Framework.Constants
         InvalidVendor = 5
     }
 
-    public enum GuildBankRights : int
+    public enum GuildBankRights
     {
         ViewTab = 0x01,
         PutItem = 0x02,

Source/Framework/Constants/Language.cs

@@ -17,7 +17,7 @@
 
 namespace Framework.Constants
 {
-    public enum Language : int
+    public enum Language
     {
         Universal = 0,
         Orcish = 1,

Source/Framework/Constants/PlayerConst.cs

@@ -32,7 +32,7 @@ namespace Framework.Constants
 
         public const int ReqPrimaryTreeTalents = 31;
         public const int ExploredZonesSize = 320;
-        public const ulong MaxMoneyAmount = ulong.MaxValue;
+        public const ulong MaxMoneyAmount = 99999999999UL;
         public const int MaxActionButtons = 132;
         public const int MaxActionButtonActionValue = 0x00FFFFFF + 1;
 

Source/Framework/Constants/Spells/SpellConst.cs

@@ -267,7 +267,7 @@ namespace Framework.Constants
     }
 
     // Spell mechanics
-    public enum Mechanics : int
+    public enum Mechanics
     {
         None = 0,
         Charm = 1,
@@ -277,7 +277,7 @@ namespace Framework.Constants
         Fear = 5,
         Grip = 6,
         Root = 7,
-        Slow_Attack = 8,
+        SlowAttack = 8,
         Silence = 9,
         Sleep = 10,
         Snare = 11,

Source/Framework/Constants/UnitConst.cs

@@ -450,6 +450,8 @@ namespace Framework.Constants
         Dead = 3,
         JustRespawned = 4
     }
+
+    [Flags]
     public enum UnitState : uint
     {
         Died = 0x01,                     // Player Has Fake Death Aura