Core/Refactor: Part 1

Source/Game/Network/Packets/BattleGroundPackets.cs

@@ -302,9 +302,9 @@ namespace Game.Network.Packets
             JoinAsGroup = _worldPacket.HasBit();
         }
 
-        public bool JoinAsGroup = false;
-        public byte Roles = 0;
-        public ulong QueueID = 0;
+        public bool JoinAsGroup;
+        public byte Roles;
+        public ulong QueueID;
         public int[] BlacklistMap = new int[2];
     }
 

Source/Game/Network/Packets/CharacterPackets.cs

@@ -627,7 +627,7 @@ namespace Game.Network.Packets
         }
 
         public ObjectGuid Guid;      // Guid of the player that is logging in
-        float FarClip = 0.0f; // Visibility distance (for terrain)
+        float FarClip; // Visibility distance (for terrain)
     }
 
     public class LoginVerifyWorld : ServerPacket
@@ -1036,13 +1036,13 @@ namespace Game.Network.Packets
         public Race RaceId = Race.None;
         public Class ClassId = Class.None;
         public Gender Sex = Gender.None;
-        public byte Skin = 0;
-        public byte Face = 0;
-        public byte HairStyle = 0;
-        public byte HairColor = 0;
-        public byte FacialHairStyle = 0;
+        public byte Skin;
+        public byte Face;
+        public byte HairStyle;
+        public byte HairColor;
+        public byte FacialHairStyle;
         public Array<byte> CustomDisplay = new Array<byte>(PlayerConst.CustomDisplaySize);
-        public byte OutfitId = 0;
+        public byte OutfitId;
         public Optional<uint> TemplateSet = new Optional<uint>();
         public string Name;
 
@@ -1058,14 +1058,14 @@ namespace Game.Network.Packets
 
     public class CharCustomizeInfo
     {
-        public byte HairStyleID = 0;
-        public byte FaceID = 0;
+        public byte HairStyleID;
+        public byte FaceID;
         public ObjectGuid CharGUID;
         public Gender SexID = Gender.None;
         public string CharName;
-        public byte HairColorID = 0;
-        public byte FacialHairStyleID = 0;
-        public byte SkinID = 0;
+        public byte HairColorID;
+        public byte FacialHairStyleID;
+        public byte SkinID;
         public Array<byte> CustomDisplay = new Array<byte>(PlayerConst.CustomDisplaySize);
     }
 
@@ -1077,7 +1077,7 @@ namespace Game.Network.Packets
         public byte SkinID;
         public byte FacialHairStyleID;
         public ObjectGuid Guid;
-        public bool FactionChange = false;
+        public bool FactionChange;
         public string Name;
         public byte FaceID;
         public byte HairStyleID;

Source/Game/Network/Packets/ChatPackets.cs

@@ -276,7 +276,7 @@ namespace Game.Network.Packets
         public string Prefix = "";
         public string Channel = "";
         public string ChatText = "";
-        public uint AchievementID = 0;
+        public uint AchievementID;
         public ChatFlags _ChatFlags = 0;
         public float DisplayTime = 0.0f;
         public bool HideChatLog = false;

Source/Game/Network/Packets/ClientConfigPackets.cs

@@ -106,8 +106,8 @@ namespace Game.Network.Packets
         }
 
         public ObjectGuid PlayerGuid;
-        public uint Time = 0; // UnixTime
-        public uint Size = 0; // decompressed size
+        public uint Time; // UnixTime
+        public uint Size; // decompressed size
         public AccountDataTypes DataType = 0;
         public ByteBuffer CompressedData;
     }

Source/Game/Network/Packets/CombatPackets.cs

@@ -92,7 +92,7 @@ namespace Game.Network.Packets
 
         public ObjectGuid Attacker;
         public ObjectGuid Victim;
-        public bool NowDead = false;
+        public bool NowDead;
     }
 
     public class ThreatUpdate : ServerPacket

Source/Game/Network/Packets/InspectPackets.cs

@@ -138,7 +138,7 @@ namespace Game.Network.Packets
             Bracket.ForEach(p => p.Write(_worldPacket));
         }
 
-        public List<PVPBracketData> Bracket;
+        public List<PVPBracketData> Bracket = new List<PVPBracketData>();
         public ObjectGuid ClientGUID;
     }
 

Source/Game/Network/Packets/MovementPackets.cs

@@ -91,7 +91,7 @@ namespace Game.Network.Packets
 
             for (uint i = 0; i < removeMovementForcesCount; ++i)
             {
-                ObjectGuid guid = data.ReadPackedGuid();
+                data.ReadPackedGuid();
             }
 
             // ResetBitReader
@@ -676,8 +676,8 @@ namespace Game.Network.Packets
         }
 
         public ObjectGuid MoverGUID;
-        int AckIndex = 0;
-        int MoveTime = 0;
+        int AckIndex;
+        int MoveTime;
     }
 
     public class MovementAckMessage : ClientPacket

Source/Game/Network/Packets/PetitionPackets.cs

@@ -34,7 +34,7 @@ namespace Game.Network.Packets
         }
 
         public ObjectGuid ItemGUID;
-        public uint PetitionID = 0;
+        public uint PetitionID;
     }
 
     public class QueryPetitionResponse : ServerPacket
@@ -156,7 +156,7 @@ namespace Game.Network.Packets
         }
 
         public ObjectGuid PetitionGUID;
-        public byte Choice = 0;
+        public byte Choice;
     }
 
     public class PetitionSignResults : ServerPacket

Source/Game/Network/Packets/SpellPackets.cs

@@ -104,8 +104,8 @@ namespace Game.Network.Packets
                 ModCooldown = cooldown;
             }
 
-            public uint Category = 0; // SpellCategory Id
-            public int ModCooldown = 0; // Reduced Cooldown in ms
+            public uint Category; // SpellCategory Id
+            public int ModCooldown; // Reduced Cooldown in ms
         }
     }
 

Source/Game/Network/Packets/TaxiPackets.cs

@@ -116,8 +116,8 @@ namespace Game.Network.Packets
 
         public ObjectGuid Vendor;
         public uint Node;
-        public uint GroundMountID = 0;
-        public uint FlyingMountID = 0;
+        public uint GroundMountID;
+        public uint FlyingMountID;
     }
 
     class NewTaxiPath : ServerPacket