Core/Misc: Moved CharacterInfo out of world to separate class

Port From (https://github.com/TrinityCore/TrinityCore/commit/ad4e63bae145ae49b584ab2fc621660430cec0d3)
2019-08-16 13:43:17 -04:00
parent ea35c2ca62
commit 3634bc7133
56 changed files with 598 additions and 527 deletions
@@ -268,7 +268,11 @@ namespace Game.Achievements
                                foreach (var skill in bounds)
                                {
                                    if (skill.SkillLine == criteria.Entry.Asset)
-                                        spellCount++;
+                                    {
+                                        // do not add couter twice if by any chance skill is listed twice in dbc (eg. skill 777 and spell 22717)
+                                        ++spellCount;
+                                        break;
+                                    }
                                }
                            }
                            SetCriteriaProgress(criteria, spellCount, referencePlayer);