Core/BattlePets: Refactor BattlePetMgr::SendUpdates
Port From (https://github.com/TrinityCore/TrinityCore/commit/c215363e86a260e9455469ffffab9e84263fb276)
This commit is contained in:
@@ -419,8 +419,7 @@ namespace Game.BattlePets
|
||||
|
||||
_pets[pet.PacketInfo.Guid.GetCounter()] = pet;
|
||||
|
||||
List<BattlePet> updates = new();
|
||||
updates.Add(pet);
|
||||
List<BattlePet> updates = [pet];
|
||||
SendUpdates(updates, true);
|
||||
|
||||
player.UpdateCriteria(CriteriaType.UniquePetsOwned);
|
||||
@@ -631,8 +630,7 @@ namespace Game.BattlePets
|
||||
if (pet.SaveInfo != BattlePetSaveInfo.New)
|
||||
pet.SaveInfo = BattlePetSaveInfo.Changed;
|
||||
|
||||
List<BattlePet> updates = new();
|
||||
updates.Add(pet);
|
||||
List<BattlePet> updates = [pet];
|
||||
SendUpdates(updates, false);
|
||||
|
||||
// UF::PlayerData::CurrentBattlePetBreedQuality isn't updated (Intended)
|
||||
@@ -653,8 +651,8 @@ namespace Game.BattlePets
|
||||
|
||||
var battlePetSpecies = CliDB.BattlePetSpeciesStorage.LookupByKey(pet.PacketInfo.Species);
|
||||
if (battlePetSpecies != null)
|
||||
if (battlePetSpecies.HasFlag(BattlePetSpeciesFlags.CantBattle))
|
||||
return;
|
||||
if (battlePetSpecies.HasFlag(BattlePetSpeciesFlags.CantBattle))
|
||||
return;
|
||||
|
||||
ushort level = pet.PacketInfo.Level;
|
||||
if (level >= SharedConst.MaxBattlePetLevel)
|
||||
@@ -695,8 +693,7 @@ namespace Game.BattlePets
|
||||
if (pet.SaveInfo != BattlePetSaveInfo.New)
|
||||
pet.SaveInfo = BattlePetSaveInfo.Changed;
|
||||
|
||||
List<BattlePet> updates = new();
|
||||
updates.Add(pet);
|
||||
List<BattlePet> updates = [pet];
|
||||
SendUpdates(updates, false);
|
||||
}
|
||||
|
||||
@@ -735,8 +732,7 @@ namespace Game.BattlePets
|
||||
if (pet.SaveInfo != BattlePetSaveInfo.New)
|
||||
pet.SaveInfo = BattlePetSaveInfo.Changed;
|
||||
|
||||
List<BattlePet> updates = new List<BattlePet>();
|
||||
updates.Add(pet);
|
||||
List<BattlePet> updates = [pet];
|
||||
SendUpdates(updates, false);
|
||||
}
|
||||
|
||||
@@ -746,17 +742,18 @@ namespace Game.BattlePets
|
||||
// regain 50 % of the damage that was taken during combat
|
||||
List<BattlePet> updates = new();
|
||||
|
||||
foreach (var pet in _pets.Values)
|
||||
foreach (var (_, pet) in _pets)
|
||||
{
|
||||
if (pet.PacketInfo.Health != pet.PacketInfo.MaxHealth)
|
||||
{
|
||||
pet.PacketInfo.Health += MathFunctions.CalculatePct(pet.PacketInfo.MaxHealth, pct);
|
||||
// don't allow Health to be greater than MaxHealth
|
||||
pet.PacketInfo.Health = Math.Min(pet.PacketInfo.Health, pet.PacketInfo.MaxHealth);
|
||||
if (pet.SaveInfo != BattlePetSaveInfo.New)
|
||||
pet.SaveInfo = BattlePetSaveInfo.Changed;
|
||||
updates.Add(pet);
|
||||
}
|
||||
if (pet.PacketInfo.Health == pet.PacketInfo.MaxHealth)
|
||||
continue;
|
||||
|
||||
pet.PacketInfo.Health += MathFunctions.CalculatePct(pet.PacketInfo.MaxHealth, pct);
|
||||
// don't allow Health to be greater than MaxHealth
|
||||
pet.PacketInfo.Health = Math.Min(pet.PacketInfo.Health, pet.PacketInfo.MaxHealth);
|
||||
if (pet.SaveInfo != BattlePetSaveInfo.New)
|
||||
pet.SaveInfo = BattlePetSaveInfo.Changed;
|
||||
|
||||
updates.Add(pet);
|
||||
}
|
||||
|
||||
SendUpdates(updates, false);
|
||||
|
||||
Reference in New Issue
Block a user