Updated all spell scripts

Source/Framework/Constants/SharedConst.cs

@@ -663,7 +663,7 @@ namespace Framework.Constants
         Hunter = 3,
         Rogue = 4,
         Priest = 5,
-        Deathknight = 6,
+        DeathKnight = 6,
         Shaman = 7,
         Mage = 8,
         Warlock = 9,
@@ -675,7 +675,7 @@ namespace Framework.Constants
         Max = 15,
 
         ClassMaskAllPlayable = ((1 << (Warrior - 1)) | (1 << (Paladin - 1)) | (1 << (Hunter - 1)) |
-            (1 << (Rogue - 1)) | (1 << (Priest - 1)) | (1 << (Deathknight - 1)) | (1 << (Shaman - 1)) |
+            (1 << (Rogue - 1)) | (1 << (Priest - 1)) | (1 << (DeathKnight - 1)) | (1 << (Shaman - 1)) |
             (1 << (Mage - 1)) | (1 << (Warlock - 1)) | (1 << (Monk - 1)) | (1 << (Druid - 1)) | (1 << (DemonHunter - 1)) | (1 << (Evoker - 1))),
 
         ClassMaskAllCreatures = ((1 << (Warrior - 1)) | (1 << (Paladin - 1)) | (1 << (Rogue - 1)) | (1 << (Mage - 1))),

Source/Framework/Util/CollectionExtensions.cs

@@ -203,6 +203,33 @@ namespace System.Collections.Generic
             while (list.Count <= index)
                 list.Add(defaultValue);
         }
+
+        public static void PartitionInPlace<T>(this IList<T> list, Func<T, bool> predicate)
+        {
+            int left = 0;
+            int right = list.Count - 1;
+
+            while (left <= right)
+            {
+                while (left <= right && predicate(list[left]))
+                {
+                    left++;
+                }
+                while (left <= right && !predicate(list[right]))
+                {
+                    right--;
+                }
+
+                if (left < right)
+                {
+                    T temp = list[left];
+                    list[left] = list[right];
+                    list[right] = temp;
+                    left++;
+                    right--;
+                }
+            }
+        }
     }
 
     public interface ICheck<in T>

Source/Game/DataStorage/CliDB.cs

@@ -845,7 +845,7 @@ namespace Game.DataStorage
                     return row.Rogue;
                 case Class.Priest:
                     return row.Priest;
-                case Class.Deathknight:
+                case Class.DeathKnight:
                     return row.DeathKnight;
                 case Class.Shaman:
                     return row.Shaman;
@@ -884,7 +884,7 @@ namespace Game.DataStorage
                     return row.Rogue;
                 case (int)Class.Priest:
                     return row.Priest;
-                case (int)Class.Deathknight:
+                case (int)Class.DeathKnight:
                     return row.DeathKnight;
                 case (int)Class.Shaman:
                     return row.Shaman;

Source/Game/DataStorage/DB2Manager.cs

@@ -1842,7 +1842,7 @@ namespace Game.DataStorage
             {
                 return playerClass switch
                 {
-                    Class.Deathknight => numTalentsAtLevel.NumTalentsDeathKnight,
+                    Class.DeathKnight => numTalentsAtLevel.NumTalentsDeathKnight,
                     Class.DemonHunter => numTalentsAtLevel.NumTalentsDemonHunter,
                     _ => numTalentsAtLevel.NumTalents,
                 };
@@ -1897,7 +1897,7 @@ namespace Game.DataStorage
             {
                 switch (class_)
                 {
-                    case Class.Deathknight:
+                    case Class.DeathKnight:
                         return _pvpTalentSlotUnlock[slot].DeathKnightLevelRequired;
                     case Class.DemonHunter:
                         return _pvpTalentSlotUnlock[slot].DemonHunterLevelRequired;

Source/Game/Entities/AreaTrigger/AreaTrigger.cs

@@ -637,7 +637,7 @@ namespace Game.Entities
                 var conditions = Global.ConditionMgr.GetConditionsForAreaTrigger(GetTemplate().Id.Id, GetTemplate().Id.IsCustom);
                 targetList.RemoveAll(target =>
                 {
-                    if (GetCasterGuid() == target.GetGUID())
+                    if (GetCasterGUID() == target.GetGUID())
                     {
                         if (HasActionSetFlag(AreaTriggerActionSetFlag.NotTriggeredbyCaster))
                             return true;
@@ -921,7 +921,7 @@ namespace Game.Entities
 
         public Unit GetCaster()
         {
-            return Global.ObjAccessor.GetUnit(this, GetCasterGuid());
+            return Global.ObjAccessor.GetUnit(this, GetCasterGUID());
         }
 
         Unit GetTarget()
@@ -1015,7 +1015,7 @@ namespace Game.Entities
             }
         }
 
-        float GetMaxSearchRadius()
+        public float GetMaxSearchRadius()
         {
             return m_areaTriggerData.BoundsRadius2D * CalcCurrentScale();
         }
@@ -1161,7 +1161,7 @@ namespace Game.Entities
                         case AreaTriggerActionTypes.Cast:
                             goto case AreaTriggerActionTypes.AddAura;
                         case AreaTriggerActionTypes.AddAura:
-                            unit.RemoveAurasDueToSpell(action.Param, GetCasterGuid());
+                            unit.RemoveAurasDueToSpell(action.Param, GetCasterGUID());
                             break;
                         case AreaTriggerActionTypes.Tavern:
                             Player player = unit.ToPlayer();
@@ -1574,9 +1574,9 @@ namespace Game.Entities
 
         public AreaTriggerCreateProperties GetCreateProperties() { return _areaTriggerCreateProperties; }
 
-        public override ObjectGuid GetCreatorGUID() { return GetCasterGuid(); }
+        public override ObjectGuid GetCreatorGUID() { return GetCasterGUID(); }
-        public override ObjectGuid GetOwnerGUID() { return GetCasterGuid(); }
+        public override ObjectGuid GetOwnerGUID() { return GetCasterGUID(); }
-        public ObjectGuid GetCasterGuid() { return m_areaTriggerData.Caster; }
+        public ObjectGuid GetCasterGUID() { return m_areaTriggerData.Caster; }
 
         public bool HasSplines() { return _spline != null && !_spline.Empty(); }
         public Spline<float> GetSpline() { return _spline; }

Source/Game/Entities/GameObject/GameObject.cs

@@ -3902,6 +3902,18 @@ namespace Game.Entities
                 command.Execute(m_goTypeImpl);
         }
 
+        public int GetControllingTeam()
+        {
+            if (GetGoType() != GameObjectTypes.ControlZone)
+                return BattleGroundTeamId.Neutral;
+
+            var controlZone = (ControlZone)m_goTypeImpl;
+            if (controlZone == null)
+                return BattleGroundTeamId.Neutral;
+
+            return controlZone.GetControllingTeam();
+        }
+
         public void CreateModel()
         {
             m_model = GameObjectModel.Create(new GameObjectModelOwnerImpl(this));
@@ -4600,7 +4612,7 @@ namespace Game.Entities
             }
         }
 
-        int GetControllingTeam()
+        public int GetControllingTeam()
         {
             if (_value < GetMaxHordeValue())
                 return BattleGroundTeamId.Horde;

Source/Game/Entities/Object/WorldObject.cs

@@ -2454,7 +2454,7 @@ namespace Game.Entities
             return spell.Prepare(targets.Targets, args.TriggeringAura);
         }
 
-        void SendPlayOrphanSpellVisual(Position sourceLocation, ObjectGuid target, uint spellVisualId, float travelSpeed, bool speedAsTime = false, bool withSourceOrientation = false)
+        public void SendPlayOrphanSpellVisual(Position sourceLocation, ObjectGuid target, uint spellVisualId, float travelSpeed, bool speedAsTime = false, bool withSourceOrientation = false)
         {
             PlayOrphanSpellVisual playOrphanSpellVisual = new();
             playOrphanSpellVisual.SourceLocation = sourceLocation;
@@ -2479,7 +2479,7 @@ namespace Game.Entities
             SendMessageToSet(playOrphanSpellVisual, true);
         }
 
-        void SendPlayOrphanSpellVisual(Position sourceLocation, Position targetLocation, uint spellVisualId, float travelSpeed, bool speedAsTime = false, bool withSourceOrientation = false)
+        public void SendPlayOrphanSpellVisual(Position sourceLocation, Position targetLocation, uint spellVisualId, float travelSpeed, bool speedAsTime = false, bool withSourceOrientation = false)
         {
             PlayOrphanSpellVisual playOrphanSpellVisual = new();
             playOrphanSpellVisual.SourceLocation = sourceLocation;

Source/Game/Entities/Pet.cs

@@ -1325,7 +1325,7 @@ namespace Game.Entities
                     {
                         case Class.Warlock:
                             return GetCreatureTemplate().CreatureType == CreatureType.Demon;
-                        case Class.Deathknight:
+                        case Class.DeathKnight:
                             return GetCreatureTemplate().CreatureType == CreatureType.Undead;
                         case Class.Mage:
                             return GetCreatureTemplate().CreatureType == CreatureType.Elemental;

Source/Game/Entities/Player/Player.Combat.cs

@@ -472,7 +472,7 @@ namespace Game.Entities
                     opponent.UpdateCriteria(CriteriaType.WinDuel, 1);
 
                     // Credit for quest Death's Challenge
-                    if (GetClass() == Class.Deathknight && opponent.GetQuestStatus(12733) == QuestStatus.Incomplete)
+                    if (GetClass() == Class.DeathKnight && opponent.GetQuestStatus(12733) == QuestStatus.Incomplete)
                         opponent.CastSpell(duel.Opponent, 52994, true);
 
                     // Honor points after duel (the winner) - ImpConfig

Source/Game/Entities/Player/Player.DB.cs

@@ -4276,7 +4276,7 @@ namespace Game.Entities
                 // Define the required variables
                 uint charDeleteMinLvl;
 
-                if (characterInfo.ClassId == Class.Deathknight)
+                if (characterInfo.ClassId == Class.DeathKnight)
                     charDeleteMinLvl = WorldConfig.GetUIntValue(WorldCfg.ChardeleteDeathKnightMinLevel);
                 else if (characterInfo.ClassId == Class.DemonHunter)
                     charDeleteMinLvl = WorldConfig.GetUIntValue(WorldCfg.ChardeleteDemonHunterMinLevel);

Source/Game/Entities/Player/Player.Spells.cs

@@ -2088,7 +2088,7 @@ namespace Game.Entities
                     ushort maxValue = GetMaxSkillValueForLevel();
                     if (rcInfo.HasFlag(SkillRaceClassInfoFlags.AlwaysMaxValue))
                         skillValue = maxValue;
-                    else if (GetClass() == Class.Deathknight)
+                    else if (GetClass() == Class.DeathKnight)
                         skillValue = (ushort)Math.Min(Math.Max(1, (GetLevel() - 1) * 5), maxValue);
 
                     SetSkill(skillId, 0, skillValue, maxValue);
@@ -2104,7 +2104,7 @@ namespace Game.Entities
                     ushort skillValue = 1;
                     if (rcInfo.HasFlag(SkillRaceClassInfoFlags.AlwaysMaxValue))
                         skillValue = maxValue;
-                    else if (GetClass() == Class.Deathknight)
+                    else if (GetClass() == Class.DeathKnight)
                         skillValue = (ushort)Math.Min(Math.Max(1, (GetLevel() - 1) * 5), maxValue);
 
                     SetSkill(skillId, 1, skillValue, maxValue);
@@ -3394,7 +3394,7 @@ namespace Game.Entities
 
         public void InitRunes()
         {
-            if (GetClass() != Class.Deathknight)
+            if (GetClass() != Class.DeathKnight)
                 return;
 
             uint runeIndex = GetPowerIndex(PowerType.Runes);
@@ -3414,7 +3414,7 @@ namespace Game.Entities
 
         public void UpdateAllRunesRegen()
         {
-            if (GetClass() != Class.Deathknight)
+            if (GetClass() != Class.DeathKnight)
                 return;
 
             uint runeIndex = GetPowerIndex(PowerType.Runes);

Source/Game/Entities/Player/Player.cs

@@ -2072,7 +2072,7 @@ namespace Game.Entities
             }
             else
             {
-                if (GetClass() == Class.Deathknight && GetMapId() == 609 && !IsGameMaster() && !HasSpell(50977))
+                if (GetClass() == Class.DeathKnight && GetMapId() == 609 && !IsGameMaster() && !HasSpell(50977))
                 {
                     SendTransferAborted(teleportLocation.Location.GetMapId(), TransferAbortReason.UniqueMessage, 1);
                     return false;
@@ -2230,7 +2230,7 @@ namespace Game.Entities
             if (CliDB.ChrRacesStorage.LookupByKey(race).HasFlag(ChrRacesFlag.IsAlliedRace))
                 startLevel = WorldConfig.GetUIntValue(WorldCfg.StartAlliedRaceLevel);
 
-            if (playerClass == Class.Deathknight)
+            if (playerClass == Class.DeathKnight)
             {
                 if (race == Race.PandarenAlliance || race == Race.PandarenHorde)
                     startLevel = Math.Max(WorldConfig.GetUIntValue(WorldCfg.StartAlliedRaceLevel), startLevel);
@@ -3587,7 +3587,7 @@ namespace Game.Entities
                     Regenerate(power);
 
             // Runes act as cooldowns, and they don't need to send any data
-            if (GetClass() == Class.Deathknight)
+            if (GetClass() == Class.DeathKnight)
             {
                 uint regeneratedRunes = 0;
                 int regenIndex = 0;
@@ -7393,7 +7393,7 @@ namespace Game.Entities
             if (node.HasFlag(TaxiNodeFlags.UsePlayerFavoriteMount) && preferredMountDisplay != 0)
                 mount_display_id = preferredMountDisplay;
             else
-                mount_display_id = ObjectMgr.GetTaxiMountDisplayId(sourcenode, GetTeam(), npc == null || (sourcenode == 315 && GetClass() == Class.Deathknight));
+                mount_display_id = ObjectMgr.GetTaxiMountDisplayId(sourcenode, GetTeam(), npc == null || (sourcenode == 315 && GetClass() == Class.DeathKnight));
 
             // in spell case allow 0 model
             if ((mount_display_id == 0 && spellid == 0) || sourcepath == 0)

Source/Game/Entities/Player/PlayerTaxi.cs

@@ -22,7 +22,7 @@ namespace Game.Entities
             m_taximask = new byte[((CliDB.TaxiNodesStorage.GetNumRows() - 1) / (1 * 64) + 1) * 8];
 
             // class specific initial known nodes
-            if (chrClass == Class.Deathknight)
+            if (chrClass == Class.DeathKnight)
             {
                 var factionMask = Player.TeamForRace(race) == Team.Horde ? DB2Manager.HordeTaxiNodesMask : DB2Manager.AllianceTaxiNodesMask;
                 m_taximask = new byte[factionMask.Length];

Source/Game/Entities/StatSystem.cs

@@ -917,7 +917,7 @@ namespace Game.Entities
             return Math.Max(missChance, 0f);
         }
 
-        float GetUnitCriticalChanceDone(WeaponAttackType attackType)
+        public float GetUnitCriticalChanceDone(WeaponAttackType attackType)
         {
             float chance = 0.0f;
             Player thisPlayer = ToPlayer();
@@ -1585,7 +1585,7 @@ namespace Game.Entities
                             ApplyAttackTimePercentMod(WeaponAttackType.OffAttack, oldVal, false);
                             ApplyAttackTimePercentMod(WeaponAttackType.BaseAttack, newVal, true);
                             ApplyAttackTimePercentMod(WeaponAttackType.OffAttack, newVal, true);
-                            if (GetClass() == Class.Deathknight)
+                            if (GetClass() == Class.DeathKnight)
                                 UpdateAllRunesRegen();
                             break;
                         case CombatRating.HasteRanged:

Source/Game/Entities/TemporarySummon.cs

@@ -623,7 +623,7 @@ namespace Game.Entities
             {
                 if (GetOwner().GetClass() == Class.Warlock
                         || GetOwner().GetClass() == Class.Shaman        // Fire Elemental
-                        || GetOwner().GetClass() == Class.Deathknight) // Risen Ghoul
+                        || GetOwner().GetClass() == Class.DeathKnight) // Risen Ghoul
                 {
                     petType = PetType.Summon;
                 }

Source/Game/Entities/Unit/Unit.Fields.cs

@@ -312,11 +312,23 @@ namespace Game.Entities
                 m_hitMask |= ProcFlagsHit.Absorb;
         }
 
+        public void ModifyDamage(ref int amount)
+        {
+            amount = Math.Max(amount, -((int)GetDamage()));
+            m_damage += (uint)amount;
+        }
         public void ModifyDamage(int amount)
         {
             amount = Math.Max(amount, -((int)GetDamage()));
             m_damage += (uint)amount;
         }
+        public void AbsorbDamage(ref uint amount)
+        {
+            amount = Math.Min(amount, GetDamage());
+            m_absorb += amount;
+            m_damage -= amount;
+            m_hitMask |= ProcFlagsHit.Absorb;
+        }
         public void AbsorbDamage(uint amount)
         {
             amount = Math.Min(amount, GetDamage());
@@ -324,7 +336,7 @@ namespace Game.Entities
             m_damage -= amount;
             m_hitMask |= ProcFlagsHit.Absorb;
         }
-        public void ResistDamage(uint amount)
+        public void ResistDamage(ref uint amount)
         {
             amount = Math.Min(amount, GetDamage());
             m_resist += amount;
@@ -335,7 +347,18 @@ namespace Game.Entities
                 m_hitMask &= ~(ProcFlagsHit.Normal | ProcFlagsHit.Critical);
             }
         }
-        void BlockDamage(uint amount)
+        public void ResistDamage(uint amount)
+        {
+            amount = Math.Min(amount, GetDamage());
+            m_resist += amount;
+            m_damage -= amount;
+            if (m_damage == 0)
+            {
+                m_hitMask |= ProcFlagsHit.FullResist;
+                m_hitMask &= ~(ProcFlagsHit.Normal | ProcFlagsHit.Critical);
+            }
+        }
+        public void BlockDamage(ref uint amount)
         {
             amount = Math.Min(amount, GetDamage());
             m_block += amount;

Source/Game/Entities/Unit/Unit.Pets.cs

@@ -528,14 +528,17 @@ namespace Game.Entities
             }
         }
 
-        public void GetAllMinionsByEntry(List<TempSummon> Minions, uint entry)
+        public List<TempSummon> GetAllMinionsByEntry(uint entry)
         {
+            List<TempSummon> minions = new();
             for (var i = 0; i < m_Controlled.Count; ++i)
             {
                 Unit unit = m_Controlled[i];
                 if (unit.GetEntry() == entry && unit.IsSummon()) // minion, actually
-                    Minions.Add(unit.ToTempSummon());
+                    minions.Add(unit.ToTempSummon());
             }
+
+            return minions;
         }
 
         public void RemoveAllMinionsByEntry(uint entry)

Source/Game/Entities/Unit/Unit.Spells.cs

@@ -2685,6 +2685,11 @@ namespace Game.Entities
             return m_appliedAuras.KeyValueList;
         }
 
+        public List<AuraApplication> GetAppliedAuras(uint key)
+        {
+            return m_appliedAuras.LookupByKey(key);
+        }
+
         public Aura AddAura(uint spellId, Unit target)
         {
             if (target == null)

Source/Game/Entities/Unit/Unit.cs

@@ -3568,7 +3568,7 @@ namespace Game.Entities
             if (spell != null)
                 spell.CallScriptOnResistAbsorbCalculateHandlers(damageInfo, ref resistedDamage, ref absorbIgnoringDamage);
 
-            damageInfo.ResistDamage(resistedDamage);
+            damageInfo.ResistDamage(ref resistedDamage);
 
             // We're going to call functions which can modify content of the list during iteration over it's elements
             // Let's copy the list so we can prevent iterator invalidation
@@ -3608,9 +3608,10 @@ namespace Game.Entities
                     // absorb must be smaller than the damage itself
                     currentAbsorb = MathFunctions.RoundToInterval(ref currentAbsorb, 0, damageInfo.GetDamage());
 
-                    damageInfo.AbsorbDamage((uint)currentAbsorb);
+                    uint temp = (uint)currentAbsorb;
+                    damageInfo.AbsorbDamage(ref temp);
+                    tempAbsorb = temp;
 
-                    tempAbsorb = (uint)currentAbsorb;
                     absorbAurEff.GetBase().CallScriptEffectAfterAbsorbHandlers(absorbAurEff, aurApp, damageInfo, ref tempAbsorb);
 
                     // Check if our aura is using amount to count heal
@@ -3625,7 +3626,7 @@ namespace Game.Entities
                 }
 
                 if (!absorbAurEff.GetSpellInfo().HasAttribute(SpellAttr6.AbsorbCannotBeIgnore))
-                    damageInfo.ModifyDamage(absorbIgnoringDamage);
+                    damageInfo.ModifyDamage(ref absorbIgnoringDamage);
 
                 if (currentAbsorb != 0)
                 {

Source/Game/Globals/ObjectManager.cs

@@ -6139,7 +6139,7 @@ namespace Game
                                         switch ((SpellCategories)itemTemplate.Effects[0].SpellCategoryID)
                                         {
                                             case SpellCategories.Food:                                // food
-                                                count = characterLoadout.ChrClassID == (int)Class.Deathknight ? 10 : 4u;
+                                                count = characterLoadout.ChrClassID == (int)Class.DeathKnight ? 10 : 4u;
                                                 break;
                                             case SpellCategories.Drink:                                // drink
                                                 count = 2;
@@ -6502,7 +6502,7 @@ namespace Game
                             continue;
 
                         // skip expansion classes if not playing with expansion
-                        if (WorldConfig.GetIntValue(WorldCfg.Expansion) < (int)Expansion.WrathOfTheLichKing && _class == Class.Deathknight)
+                        if (WorldConfig.GetIntValue(WorldCfg.Expansion) < (int)Expansion.WrathOfTheLichKing && _class == Class.DeathKnight)
                             continue;
 
                         if (WorldConfig.GetIntValue(WorldCfg.Expansion) < (int)Expansion.MistsOfPandaria && (race == Race.PandarenNeutral || race == Race.PandarenHorde || race == Race.PandarenAlliance))

Source/Game/Handlers/CharacterHandler.cs

@@ -2018,7 +2018,7 @@ namespace Game
                         {
                             // i = (315 - 1) / 8 = 39
                             // m = 1 << ((315 - 1) % 8) = 4
-                            int deathKnightExtraNode = playerClass != Class.Deathknight || i != 39 ? 0 : 4;
+                            int deathKnightExtraNode = playerClass != Class.DeathKnight || i != 39 ? 0 : 4;
                             taximaskstream += (uint)(factionMask[i] | deathKnightExtraNode) + ' ';
                         }
 

Source/Game/Handlers/SpellHandler.cs

@@ -630,7 +630,7 @@ namespace Game
             if (target == null)
                 return;
 
-            if (target.GetCasterGuid() != _player.GetGUID())
+            if (target.GetCasterGUID() != _player.GetGUID())
                 return;
 
             SpellInfo spellInfo = Global.SpellMgr.GetSpellInfo(target.m_areaTriggerData.SpellForVisuals, _player.GetMap().GetDifficultyID());

Source/Game/Maps/GridNotifiers.cs

@@ -687,6 +687,7 @@ namespace Game.Maps
         WorldObjectSearcherContinuation ShouldContinue();
         void Insert(T obj);
         T GetResult();
+        bool HasResult();
     }
 
     class SearcherFirstObjectResult<T>() : IResultInserter<T>
@@ -703,6 +704,11 @@ namespace Game.Maps
             result = obj;
         }
 
+        public bool HasResult()
+        {
+            return result != null;
+        }
+
         public T GetResult()
         {
             return result;
@@ -723,6 +729,11 @@ namespace Game.Maps
             result = obj;
         }
 
+        public bool HasResult()
+        {
+            return result != null;
+        }
+
         public T GetResult()
         {
             return result;
@@ -743,6 +754,11 @@ namespace Game.Maps
             container.Add(obj);
         }
 
+        public bool HasResult()
+        {
+            return !container.Empty();
+        }
+
         public T GetResult()
         {
             return default;
@@ -876,6 +892,11 @@ namespace Game.Maps
             }
         }
 
+        public bool HasResult()
+        {
+            return resultInserter.HasResult();
+        }
+
         public T GetResult()
         {
             return resultInserter.GetResult();

Source/Game/Networking/Packets/CharacterPackets.cs

@@ -152,7 +152,7 @@ namespace Game.Networking.Packets
                 FirstLogin = atLoginFlags.HasAnyFlag(AtLoginFlags.FirstLogin);
 
                 // show pet at selection character in character list only for non-ghost character
-                if (!playerFlags.HasAnyFlag(PlayerFlags.Ghost) && (ClassId == Class.Warlock || ClassId == Class.Hunter || ClassId == Class.Deathknight))
+                if (!playerFlags.HasAnyFlag(PlayerFlags.Ghost) && (ClassId == Class.Warlock || ClassId == Class.Hunter || ClassId == Class.DeathKnight))
                 {
                     CreatureTemplate creatureInfo = Global.ObjectMgr.GetCreatureTemplate(fields.Read<uint>(14));
                     if (creatureInfo != null)

Source/Game/Scripting/ScriptManager.cs

@@ -74,7 +74,7 @@ namespace Game.Scripting
                     var constructors = type.GetConstructors();
                     if (constructors.Length == 0)
                     {
-                        Log.outError(LogFilter.Scripts, "Script: {0} contains no Public Constructors. Can't load script.", type.Name);
+                        Log.outError(LogFilter.Scripts, $"Script: {type.Name} contains no Public Constructors. Can't load script.");
                         continue;
                     }
 
@@ -84,16 +84,15 @@ namespace Game.Scripting
                         string name = type.Name;
 
                         bool validArgs = true;
-                        int i = 0;
                         foreach (var constructor in constructors)
                         {
                             var parameters = constructor.GetParameters();
                             if (parameters.Length != attribute.Args.Length)
                                 continue;
 
-                            foreach (var arg in constructor.GetParameters())
+                            for (var i = 0; i < parameters.Length; ++i)
                             {
-                                if (arg.ParameterType != attribute.Args[i++].GetType())
+                                if (attribute.Args[i] != null && attribute.Args[i].GetType() != parameters[i].ParameterType)
                                 {
                                     validArgs = false;
                                     break;
@@ -110,6 +109,9 @@ namespace Game.Scripting
                             continue;
                         }
 
+                        if (!attribute.Name.IsEmpty())
+                            name = attribute.Name;
+
                         switch (type.BaseType.Name)
                         {
                             case nameof(SpellScript):
@@ -129,6 +131,9 @@ namespace Game.Scripting
                             case nameof(ConversationAI):
                                 genericType = typeof(GenericConversationScript<>).MakeGenericType(type);
                                 break;
+                            case nameof(BattlegroundScript):
+                                genericType = typeof(GenericBattlegroundMapScript<>).MakeGenericType(type);
+                                break;
                             case "SpellScriptLoader":
                             case "AuraScriptLoader":
                             case "WorldScript":
@@ -161,22 +166,16 @@ namespace Game.Scripting
                             case "AchievementScript":
                             case "BattlefieldScript":
                             case "EventScript":
-                                if (!attribute.Name.IsEmpty())
-                                    name = attribute.Name;
-
                                 if (attribute.Args.Empty())
                                     Activator.CreateInstance(genericType);
                                 else
-                                    Activator.CreateInstance(genericType, new object[] { name }.Combine(attribute.Args));
+                                    Activator.CreateInstance(genericType, name, attribute.Args);
                                 continue;
                             default:
                                 genericType = typeof(GenericCreatureScript<>).MakeGenericType(type);
                                 break;
                         }
 
-                        if (!attribute.Name.IsEmpty())
-                            name = attribute.Name;
-
                         Activator.CreateInstance(genericType, name, attribute.Args);
                     }
                 }

Source/Game/Scripting/SpellScript.cs

@@ -30,7 +30,7 @@ namespace Game.Scripting
             return true;
         }
 
-        public bool ValidateSpellInfo(params uint[] spellIds)
+        public static bool ValidateSpellInfo(params uint[] spellIds)
         {
             bool allValid = true;
             foreach (uint spellId in spellIds)
@@ -45,7 +45,7 @@ namespace Game.Scripting
             return allValid;
         }
 
-        public bool ValidateSpellEffect(params (uint spellId, uint effectIndex)[] pairs)
+        public static bool ValidateSpellEffect(params (uint spellId, uint effectIndex)[] pairs)
         {
             bool allValid = true;
             foreach (var (spellId, effectIndex) in pairs)
@@ -56,7 +56,7 @@ namespace Game.Scripting
             return allValid;
         }
 
-        public bool ValidateSpellEffect(uint spellId, uint effectIndex)
+        public static bool ValidateSpellEffect(uint spellId, uint effectIndex)
         {
             SpellInfo spellInfo = Global.SpellMgr.GetSpellInfo(spellId, Difficulty.None);
             if (spellInfo == null)

Source/Game/Spells/Spell.cs

@@ -4047,7 +4047,7 @@ namespace Game.Spells
             if ((m_caster.IsPlayer() || (m_caster.IsTypeId(TypeId.Unit) && m_caster.ToCreature().IsPet())) && m_powerCost.Any(cost => cost.Power != PowerType.Health))
                 castFlags |= SpellCastFlags.PowerLeftSelf;
 
-            if (m_caster.IsPlayer() && m_caster.ToPlayer().GetClass() == Class.Deathknight &&
+            if (m_caster.IsPlayer() && m_caster.ToPlayer().GetClass() == Class.DeathKnight &&
                 HasPowerTypeCost(PowerType.Runes) && !_triggeredCastFlags.HasAnyFlag(TriggerCastFlags.IgnorePowerCost))
             {
                 castFlags |= SpellCastFlags.NoGCD; // not needed, but it's being sent according to sniffs
@@ -4820,7 +4820,7 @@ namespace Game.Spells
             if (player == null)
                 return SpellCastResult.SpellCastOk;
 
-            if (player.GetClass() != Class.Deathknight)
+            if (player.GetClass() != Class.DeathKnight)
                 return SpellCastResult.SpellCastOk;
 
             int readyRunes = 0;
@@ -4836,7 +4836,7 @@ namespace Game.Spells
 
         void TakeRunePower(bool didHit)
         {
-            if (!m_caster.IsTypeId(TypeId.Player) || m_caster.ToPlayer().GetClass() != Class.Deathknight)
+            if (!m_caster.IsTypeId(TypeId.Player) || m_caster.ToPlayer().GetClass() != Class.DeathKnight)
                 return;
 
             Player player = m_caster.ToPlayer();
@@ -4858,7 +4858,7 @@ namespace Game.Spells
 
         void RefundRunePower()
         {
-            if (!m_caster.IsPlayer() || m_caster.ToPlayer().GetClass() != Class.Deathknight)
+            if (!m_caster.IsPlayer() || m_caster.ToPlayer().GetClass() != Class.DeathKnight)
                 return;
 
             Player player = m_caster.ToPlayer();
@@ -6578,7 +6578,7 @@ namespace Game.Spells
             return unit.HasUnitMovementFlag(MovementFlag.Forward | MovementFlag.StrafeLeft | MovementFlag.StrafeRight | MovementFlag.Falling) && !unit.IsWalking();
         }
 
-        (float minRange, float maxRange) GetMinMaxRange(bool strict)
+        public (float minRange, float maxRange) GetMinMaxRange(bool strict)
         {
             float rangeMod = 0.0f;
             float minRange = 0.0f;
@@ -8421,7 +8421,7 @@ namespace Game.Spells
             return SpellCastResult.SpellCastOk;
         }
 
-        int CalculateDamage(SpellEffectInfo spellEffectInfo, Unit target)
+        public int CalculateDamage(SpellEffectInfo spellEffectInfo, Unit target)
         {
             return CalculateDamage(spellEffectInfo, target, out _);
         }

Source/Game/Spells/SpellHistory.cs

@@ -857,7 +857,7 @@ namespace Game.Spells
             _categoryCharges.Add(chargeCategoryId, new ChargeEntry(recoveryStart, TimeSpan.FromMilliseconds(chargeRecovery)));
         }
 
-        void ModifyChargeRecoveryTime(uint chargeCategoryId, TimeSpan cooldownMod)
+        public void ModifyChargeRecoveryTime(uint chargeCategoryId, TimeSpan cooldownMod)
         {
             var chargeCategoryEntry = CliDB.SpellCategoryStorage.LookupByKey(chargeCategoryId);
             if (chargeCategoryEntry == null)
@@ -1119,12 +1119,19 @@ namespace Game.Spells
             }
         }
 
-        void GetCooldownDurations(SpellInfo spellInfo, uint itemId, ref uint categoryId)
+        public static void GetCooldownDurations(SpellInfo spellInfo, uint itemId, ref uint categoryId)
         {
             TimeSpan notUsed = TimeSpan.Zero;
             GetCooldownDurations(spellInfo, itemId, ref notUsed, ref categoryId, ref notUsed);
         }
 
+        public static void GetCooldownDurations(SpellInfo spellInfo, uint itemId, ref TimeSpan cooldown)
+        {
+            TimeSpan notUsed = TimeSpan.Zero;
+            uint notUsedId = 0;
+            GetCooldownDurations(spellInfo, itemId, ref cooldown, ref notUsedId, ref notUsed);
+        }
+
         public static void GetCooldownDurations(SpellInfo spellInfo, uint itemId, ref TimeSpan cooldown, ref uint categoryId, ref TimeSpan categoryCooldown)
         {
             TimeSpan tmpCooldown = TimeSpan.MinValue;