Core/Threat: Threat system adjustments

Port From (https://github.com/TrinityCore/TrinityCore/commit/392a644dc8562ea54b9c185a2776fceb1006e2cd)

Source/Game/Entities/Creature/Creature.cs

@@ -417,7 +417,7 @@ namespace Game.Entities
             LoadCreaturesAddon();
             LoadTemplateImmunities();
 
-            GetThreatManager().UpdateOnlineStates(true, true);
+            GetThreatManager().EvaluateSuppressed();
             return true;
         }
 
@@ -541,7 +541,6 @@ namespace Game.Entities
                         if (diff >= m_boundaryCheckTime)
                         {
                             GetAI().CheckInRoom();
-                            GetThreatManager().UpdateOnlineStates(false, true);
                             m_boundaryCheckTime = 2500;
                         }
                         else
@@ -898,7 +897,7 @@ namespace Game.Entities
             Unit target;
 
             if (CanHaveThreatList())
-                target = GetThreatManager().SelectVictim();
+                target = GetThreatManager().GetCurrentVictim();
             else if (!HasReactState(ReactStates.Passive))
             {
                 // We're a player pet, probably

Source/Game/Entities/Unit/Unit.Combat.cs

@@ -152,8 +152,6 @@ namespace Game.Entities
 
         public bool CanHaveThreatList() { return m_threatManager.CanHaveThreatList(); }
 
-        void SendThreatListUpdate() { m_threatManager.SendThreatListToClients(); }
-
         // For NPCs with threat list: Whether there are any enemies on our threat list
         // For other units: Whether we're in combat
         // This value is different from IsInCombat when a projectile spell is midair (combat on launch - threat+aggro on impact)

Source/Game/Entities/Unit/Unit.cs

@@ -419,7 +419,6 @@ namespace Game.Entities
                 AddToNotify(NotifyFlags.VisibilityChanged);
             else
             {
-                m_threatManager.UpdateOnlineStates(true, true);
                 base.UpdateObjectVisibility(true);
                 // call MoveInLineOfSight for nearby creatures
                 AIRelocationNotifier notifier = new(this);
@@ -2882,16 +2881,11 @@ namespace Game.Entities
             {
                 AddUnitFlag(UnitFlags.ImmuneToPc | UnitFlags.ImmuneToNpc);
                 ValidateAttackersAndOwnTarget();
-                if (keepCombat)
-                    m_threatManager.UpdateOnlineStates(true, true);
-                else
+                if (!keepCombat)
                     m_combatManager.EndAllCombat();
             }
             else
-            {
                 RemoveUnitFlag(UnitFlags.ImmuneToPc | UnitFlags.ImmuneToNpc);
-                m_threatManager.UpdateOnlineStates(true, true);
-            }
         }
 
         public virtual void SetImmuneToAll(bool apply) { SetImmuneToAll(apply, false); }
@@ -2904,9 +2898,7 @@ namespace Game.Entities
             {
                 AddUnitFlag(UnitFlags.ImmuneToPc);
                 ValidateAttackersAndOwnTarget();
-                if (keepCombat)
-                    m_threatManager.UpdateOnlineStates(true, true);
-                else
+                if (!keepCombat)
                 {
                     List<CombatReference> toEnd = new();
                     foreach (var pair in m_combatManager.GetPvECombatRefs())
@@ -2922,10 +2914,7 @@ namespace Game.Entities
                 }
             }
             else
-            {
                 RemoveUnitFlag(UnitFlags.ImmuneToPc);
-                m_threatManager.UpdateOnlineStates(true, true);
-            }
         }
 
         public virtual void SetImmuneToPC(bool apply) { SetImmuneToPC(apply, false); }
@@ -2938,9 +2927,7 @@ namespace Game.Entities
             {
                 AddUnitFlag(UnitFlags.ImmuneToNpc);
                 ValidateAttackersAndOwnTarget();
-                if (keepCombat)
-                    m_threatManager.UpdateOnlineStates(true, true);
-                else
+                if (!keepCombat)
                 {
                     List<CombatReference> toEnd = new();
                     foreach (var pair in m_combatManager.GetPvECombatRefs())
@@ -2956,10 +2943,7 @@ namespace Game.Entities
                 }
             }
             else
-            {
                 RemoveUnitFlag(UnitFlags.ImmuneToNpc);
-                m_threatManager.UpdateOnlineStates(true, true);
-            }
         }
 
         public virtual void SetImmuneToNPC(bool apply) { SetImmuneToNPC(apply, false); }