Core/Misc: Cleanups

Source/Game/DataStorage/ClientReader/BitReader.cs

@@ -137,10 +137,6 @@ namespace Game.DataStorage
         {
             var val = ((bitSize + 7) / 8);
             var val1 = NextPow2((bitSize + 7) / 8);
-            if (val != val1)
-            {
-
-            }
 
             byte[] data = new byte[NextPow2((bitSize + 7) / 8)];
             unsafe

Source/Game/Entities/Unit/Unit.Movement.cs

@@ -1537,18 +1537,18 @@ namespace Game.Entities
             Player playerMover = GetPlayerBeingMoved();
             if (playerMover)
             {
-                MoveTeleport moveTeleport = new MoveTeleport();
-                moveTeleport.MoverGUID = GetGUID();
-                moveTeleport.Pos = pos;
+                float x, y, z, o;
+                pos.GetPosition(out x, out y, out z, out o);
 
                 ITransport transportBase = GetDirectTransport();
                 if (transportBase != null)
-                {
-                    float o = 0f;
-                    transportBase.CalculatePassengerOffset(ref moveTeleport.Pos.posX, ref moveTeleport.Pos.posY, ref moveTeleport.Pos.posZ, ref o);
-                }
+                    transportBase.CalculatePassengerOffset(ref x, ref y, ref z, ref o);
+
+                MoveTeleport moveTeleport = new MoveTeleport();
+                moveTeleport.MoverGUID = GetGUID();
+                moveTeleport.Pos = new Position(x, y, z, o);
                 moveTeleport.TransportGUID.Set(GetTransGUID());
-                moveTeleport.Facing = pos.GetOrientation();
+                moveTeleport.Facing = o;
                 moveTeleport.SequenceIndex = m_movementCounter++;
                 playerMover.SendPacket(moveTeleport);
 

Source/Game/Maps/TransportManager.cs

@@ -61,7 +61,7 @@ namespace Game.Maps
                     continue;
                 }
 
-                if (goInfo.MoTransport.taxiPathID >= CliDB.TaxiPathNodesByPath.Keys.Max())
+                if (!CliDB.TaxiPathNodesByPath.ContainsKey(goInfo.MoTransport.taxiPathID))
                 {
                     Log.outError(LogFilter.Sql, "Transport {0} (name: {1}) has an invalid path specified in `gameobject_template`.`data0` ({2}) field, skipped.", entry, goInfo.name, goInfo.MoTransport.taxiPathID);
                     continue;

Source/WorldServer/Server.cs

@@ -186,6 +186,7 @@ namespace WorldServer
         static void ExitNow()
         {
             Log.outInfo(LogFilter.Server, "Halting process...");
+            Thread.Sleep(5000);
             Environment.Exit(-1);
         }
     }

Source/WorldServer/WorldServer.conf.dist

@@ -42,18 +42,18 @@ LoginDatabaseInfo.Username = "username"
 LoginDatabaseInfo.Password = "password"
 LoginDatabaseInfo.Database = "auth"
 
-WorldDatabaseInfo.Host = "127.0.0.1"
-WorldDatabaseInfo.Port = "3306"
-WorldDatabaseInfo.Username = "username"
-WorldDatabaseInfo.Password = "password"
-WorldDatabaseInfo.Database = "world"
-
 CharacterDatabaseInfo.Host = "127.0.0.1"
 CharacterDatabaseInfo.Port = "3306"
 CharacterDatabaseInfo.Username = "username"
 CharacterDatabaseInfo.Password = "password"
 CharacterDatabaseInfo.Database = "characters"
 
+WorldDatabaseInfo.Host = "127.0.0.1"
+WorldDatabaseInfo.Port = "3306"
+WorldDatabaseInfo.Username = "username"
+WorldDatabaseInfo.Password = "password"
+WorldDatabaseInfo.Database = "world"
+
 HotfixDatabaseInfo.Host = "127.0.0.1"
 HotfixDatabaseInfo.Port = "3306"
 HotfixDatabaseInfo.Username = "username"