Inna/CypherCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Core/Spells: Fixed spell effect value truncation when value is a large integer

Browse Source 
Port From (https://github.com/TrinityCore/TrinityCore/commit/2d205506bfd3a2bb253db73b121fd147928811ba)
This commit is contained in:
hondacrx
2022-12-28 15:31:42 -05:00
parent 989b80b056
commit 3fcafdfa80
3 changed files with 17 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/Game/Spells/SpellInfo.cs
+6 -6
View File
@@ -4171,11 +4171,11 @@ namespace Game.Spells
public int CalcValue(out float variance, WorldObject caster = null, int? bp = null, Unit target = null, uint castItemId = 0, int itemLevel = -1)
{
variance = 0.0f;
float basePointsPerLevel = RealPointsPerLevel;
double basePointsPerLevel = RealPointsPerLevel;
// TODO: this needs to be a float, not rounded
int basePoints = CalcBaseValue(caster, target, castItemId, itemLevel);
float value = bp.HasValue ? bp.Value : basePoints;
float comboDamage = PointsPerResource;
double value = bp.HasValue ? bp.Value : basePoints;
double comboDamage = PointsPerResource;
Unit casterUnit = null;
if (caster != null)
@@ -4184,9 +4184,9 @@ namespace Game.Spells
if (Scaling.Variance != 0)
{
float delta = Math.Abs(Scaling.Variance * 0.5f);
float valueVariance = RandomHelper.FRand(-delta, delta);
value += basePoints * valueVariance;
variance = valueVariance;
double valueVariance = RandomHelper.FRand(-delta, delta);
value += (double)basePoints * valueVariance;
variance = (float)valueVariance;
}
// base amount modification based on spell lvl vs caster lvl