Core/PacketIO: Named a bunch of unknown/unused fields

Port From (https://github.com/TrinityCore/TrinityCore/commit/806611075659ddde60f3003763e442a46d70f993)
This commit is contained in:
Hondacrx
2024-11-17 13:07:52 -05:00
parent ba80dede79
commit 447c222665
41 changed files with 525 additions and 516 deletions
@@ -137,13 +137,12 @@ namespace Game.Networking.Packets
_worldPacket.FlushBits();
{
_worldPacket.WriteUInt32(SuccessInfo.GameTimeInfo.BillingPlan);
_worldPacket.WriteUInt32(SuccessInfo.GameTimeInfo.TimeRemain);
_worldPacket.WriteUInt32(SuccessInfo.GameTimeInfo.Unknown735);
// 3x same bit is not a mistake - preserves legacy client behavior of BillingPlanFlags::SESSION_IGR
_worldPacket.WriteBit(SuccessInfo.GameTimeInfo.InGameRoom); // inGameRoom check in function checking which lua event to fire when remaining time is near end - BILLING_NAG_DIALOG vs IGR_BILLING_NAG_DIALOG
_worldPacket.WriteBit(SuccessInfo.GameTimeInfo.InGameRoom); // inGameRoom lua return from Script_GetBillingPlan
_worldPacket.WriteBit(SuccessInfo.GameTimeInfo.InGameRoom); // not used anywhere in the client
_worldPacket.WriteUInt32(SuccessInfo.GameTimeInfo.BillingType);
_worldPacket.WriteUInt32(SuccessInfo.GameTimeInfo.MinutesRemaining);
_worldPacket.WriteUInt32(SuccessInfo.GameTimeInfo.RealBillingType);
_worldPacket.WriteBit(SuccessInfo.GameTimeInfo.IsInIGR); // inGameRoom check in function checking which lua event to fire when remaining time is near end - BILLING_NAG_DIALOG vs IGR_BILLING_NAG_DIALOG
_worldPacket.WriteBit(SuccessInfo.GameTimeInfo.IsPaidForByIGR); // inGameRoom lua return from Script_GetBillingPlan
_worldPacket.WriteBit(SuccessInfo.GameTimeInfo.IsCAISEnabled); // not used anywhere in the client
_worldPacket.FlushBits();
}
@@ -222,10 +221,12 @@ namespace Game.Networking.Packets
public struct GameTime
{
public uint BillingPlan;
public uint TimeRemain;
public uint Unknown735;
public bool InGameRoom;
public uint BillingType;
public uint MinutesRemaining;
public uint RealBillingType;
public bool IsInIGR;
public bool IsPaidForByIGR;
public bool IsCAISEnabled;
}
public class NewBuild