Core/Misc: Changed GetLocaleByName to return invalid value on invalid input instead of LOCALE_enUS

Port From (https://github.com/TrinityCore/TrinityCore/commit/79cd94d26df33a332586b2aa72a99b123199c88f)
2020-07-14 17:11:56 -04:00
parent e179d29b55
commit 4bb9823456
5 changed files with 21 additions and 16 deletions
@@ -1328,7 +1328,7 @@ namespace Game.Achievements

                AchievementRewardLocale data = new AchievementRewardLocale();
                Locale locale = localeName.ToEnum<Locale>();
-                if (locale == Locale.enUS)
+                if (!SharedConst.IsValidLocale(locale) || locale  == Locale.enUS)
                    continue;

                ObjectManager.AddLocaleString(result.Read<string>(2), locale, data.Subject);