Core/Spells: Cleanup spell effects

Port From (https://github.com/TrinityCore/TrinityCore/commit/8a4e1119ac21e2d1112d1717337597fe073e495f)
2021-09-08 17:40:50 -04:00
parent 2af5cad79f
commit 5c4a7511ff
41 changed files with 2378 additions and 1987 deletions
@@ -5136,9 +5136,10 @@ namespace Game.Entities
                    CastSpellExtraArgs args = new(TriggerCastFlags.FullMask);
                    args.CastItem = artifact;
                    if (artifactPowerRank.AuraPointsOverride != 0)
-                        for (int i = 0; i < SpellConst.MaxEffects; ++i)
-                            if (spellInfo.GetEffect((uint)i) != null)
-                                args.AddSpellMod(SpellValueMod.BasePoint0 + i, (int)artifactPowerRank.AuraPointsOverride);
+                    {
+                        foreach (var spellEffectInfo in spellInfo.GetEffects())
+                            args.AddSpellMod(SpellValueMod.BasePoint0 + (int)spellEffectInfo.EffectIndex, (int)artifactPowerRank.AuraPointsOverride);
+                    }

                    CastSpell(this, artifactPowerRank.SpellID, args);
                }