Core/DataStores: Removed overriding field sign type based on db2 column compression

Port From (https://github.com/TrinityCore/TrinityCore/commit/89f490bdcdf88c2576c17218926e89b1082ae682)

Source/Game/DataStorage/CliDB.cs

@@ -439,7 +439,7 @@ namespace Game.DataStorage
                 if (node.HasFlag(TaxiNodeFlags.ShowOnAllianceMap))
                     AllianceTaxiNodesMask[field] |= submask;
 
-                int uiMapId;
+                uint uiMapId;
                 if (!Global.DB2Mgr.GetUiMapPosition(node.Pos.X, node.Pos.Y, node.Pos.Z, node.ContinentID, 0, 0, 0, UiMapSystem.Adventure, false, out uiMapId))
                     Global.DB2Mgr.GetUiMapPosition(node.Pos.X, node.Pos.Y, node.Pos.Z, node.ContinentID, 0, 0, 0, UiMapSystem.Taxi, false, out uiMapId);
 

Source/Game/DataStorage/DB2Manager.cs

@@ -575,7 +575,7 @@ namespace Game.DataStorage
                 _uiMapAssignmentByWmoGroup[i] = new MultiMap<int, UiMapAssignmentRecord>();
             }
 
-            MultiMap<int, UiMapAssignmentRecord> uiMapAssignmentByUiMap = new();
+            MultiMap<uint, UiMapAssignmentRecord> uiMapAssignmentByUiMap = new();
             foreach (UiMapAssignmentRecord uiMapAssignment in UiMapAssignmentStorage.Values)
             {
                 uiMapAssignmentByUiMap.Add(uiMapAssignment.UiMapID, uiMapAssignment);
@@ -594,9 +594,9 @@ namespace Game.DataStorage
                 }
             }
 
-            Dictionary<Tuple<int, uint>, UiMapLinkRecord> uiMapLinks = new();
+            Dictionary<Tuple<uint, int>, UiMapLinkRecord> uiMapLinks = new();
             foreach (UiMapLinkRecord uiMapLink in UiMapLinkStorage.Values)
-                uiMapLinks[Tuple.Create(uiMapLink.ParentUiMapID, (uint)uiMapLink.ChildUiMapID)] = uiMapLink;
+                uiMapLinks[Tuple.Create(uiMapLink.ParentUiMapID, uiMapLink.ChildUiMapID)] = uiMapLink;
 
             foreach (UiMapRecord uiMap in UiMapStorage.Values)
             {
@@ -1022,7 +1022,7 @@ namespace Game.DataStorage
             return broadcastText.Text[SharedConst.DefaultLocale];
         }
 
-        public int GetBroadcastTextDuration(int broadcastTextId, Locale locale = Locale.enUS)
+        public int GetBroadcastTextDuration(uint broadcastTextId, Locale locale = Locale.enUS)
         {
             return _broadcastTextDurations.LookupByKey((broadcastTextId, SharedConst.WowLocaleToCascLocaleBit[(int)locale]));
         }
@@ -2185,7 +2185,7 @@ namespace Game.DataStorage
             return nearestMapAssignment.UiMapAssignment;
         }
 
-        Vector2 CalculateGlobalUiMapPosition(int uiMapID, Vector2 uiPosition)
+        Vector2 CalculateGlobalUiMapPosition(uint uiMapID, Vector2 uiPosition)
         {
             UiMapRecord uiMap = UiMapStorage.LookupByKey(uiMapID);
             while (uiMap != null)
@@ -2211,14 +2211,14 @@ namespace Game.DataStorage
             return GetUiMapPosition(x, y, z, mapId, areaId, wmoDoodadPlacementId, wmoGroupId, system, local, out _, out newPos);
         }
 
-        public bool GetUiMapPosition(float x, float y, float z, int mapId, int areaId, int wmoDoodadPlacementId, int wmoGroupId, UiMapSystem system, bool local, out int uiMapId)
+        public bool GetUiMapPosition(float x, float y, float z, int mapId, int areaId, int wmoDoodadPlacementId, int wmoGroupId, UiMapSystem system, bool local, out uint uiMapId)
         {
             return GetUiMapPosition(x, y, z, mapId, areaId, wmoDoodadPlacementId, wmoGroupId, system, local, out uiMapId, out _);
         }
 
-        public bool GetUiMapPosition(float x, float y, float z, int mapId, int areaId, int wmoDoodadPlacementId, int wmoGroupId, UiMapSystem system, bool local, out int uiMapId, out Vector2 newPos)
+        public bool GetUiMapPosition(float x, float y, float z, int mapId, int areaId, int wmoDoodadPlacementId, int wmoGroupId, UiMapSystem system, bool local, out uint uiMapId, out Vector2 newPos)
         {
-            uiMapId = -1;
+            uiMapId = uint.MaxValue;
             newPos = new Vector2();
 
             UiMapAssignmentRecord uiMapAssignment = FindNearestMapAssignment(x, y, z, mapId, areaId, wmoDoodadPlacementId, wmoGroupId, system);
@@ -2322,7 +2322,7 @@ namespace Game.DataStorage
         AzeriteItemMilestonePowerRecord[] _azeriteItemMilestonePowerByEssenceSlot = new AzeriteItemMilestonePowerRecord[SharedConst.MaxAzeriteEssenceSlot];
         MultiMap<uint, AzeritePowerSetMemberRecord> _azeritePowers = new();
         Dictionary<(uint azeriteUnlockSetId, ItemContext itemContext), byte[]> _azeriteTierUnlockLevels = new();
-        Dictionary<(int broadcastTextId, CascLocaleBit cascLocaleBit), int> _broadcastTextDurations = new();
+        Dictionary<(uint broadcastTextId, CascLocaleBit cascLocaleBit), int> _broadcastTextDurations = new();
         Dictionary<(sbyte, sbyte), CharBaseInfoRecord> _charBaseInfoByRaceAndClass = new();
         ChrClassUIDisplayRecord[] _uiDisplayByClass = new ChrClassUIDisplayRecord[(int)Class.Max];
         uint[][] _powersByClass = new uint[(int)Class.Max][];

Source/Game/DataStorage/Structs/A_Records.cs

@@ -35,7 +35,7 @@ namespace Game.DataStorage
         public LocalizedString Name;
         public uint Id;
         public short Parent;
-        public sbyte UiOrder;
+        public byte UiOrder;
     }
 
     public sealed class AdventureJournalRecord

Source/Game/DataStorage/Structs/B_Records.cs

@@ -36,7 +36,7 @@ namespace Game.DataStorage
         public uint Id;
         public int MaxQualityRoll;
         public float StateMultiplier;
-        public sbyte QualityEnum;
+        public byte QualityEnum;
     }
 
     public sealed class BattlePetBreedStateRecord
@@ -122,7 +122,7 @@ namespace Game.DataStorage
     public sealed class BroadcastTextDurationRecord
     {
         public uint Id;
-        public int BroadcastTextID;
+        public uint BroadcastTextID;
         public int Locale;
         public int Duration;
     }

Source/Game/DataStorage/Structs/C_Records.cs

@@ -64,7 +64,7 @@ namespace Game.DataStorage
         public long RaceMask;
         public sbyte ChrClassID;
         public int Purpose;
-        public sbyte ItemContext;
+        public byte ItemContext;
 
         public bool IsForNewCharacter() { return Purpose == 9; }
     }
@@ -255,7 +255,7 @@ namespace Game.DataStorage
     public sealed class ChrRaceXChrModelRecord
     {
         public uint Id;
-        public int ChrRacesID;
+        public uint ChrRacesID;
         public int ChrModelID;
         public int Sex;
         public int AllowedTransmogSlots;

Source/Game/DataStorage/Structs/D_Records.cs

@@ -43,7 +43,7 @@ namespace Game.DataStorage
         public byte MinPlayers;
         public byte MaxPlayers;
         public ushort Flags;
-        public sbyte ItemContext;
+        public byte ItemContext;
         public byte ToggleDifficultyID;
         public uint GroupSizeHealthCurveID;
         public uint GroupSizeDmgCurveID;
@@ -56,7 +56,7 @@ namespace Game.DataStorage
     {
         public LocalizedString Name;
         public uint Id;
-        public short MapID;
+        public ushort MapID;
         public int DifficultyID;
         public int OrderIndex;
         public int CompleteWorldStateID;

Source/Game/DataStorage/Structs/F_Records.cs

@@ -96,7 +96,7 @@ namespace Game.DataStorage
     {
         public uint Id;
         public LocalizedString Reaction;
-        public int FriendshipRepID;
+        public uint FriendshipRepID;
         public int ReactionThreshold;
         public int OverrideColor;
     }

Source/Game/DataStorage/Structs/G_Records.cs

@@ -77,7 +77,7 @@ namespace Game.DataStorage
         public string Description;
         public string Tooltip;
         public sbyte GarrTypeID;
-        public sbyte BuildingType;
+        public byte BuildingType;
         public uint HordeGameObjectID;
         public uint AllianceGameObjectID;
         public int GarrSiteID;
@@ -187,7 +187,7 @@ namespace Game.DataStorage
         public uint EnvGarrMechanicID;
         public int EnvGarrMechanicTypeID;
         public uint PlayerConditionID;
-        public int GarrMissionSetID;
+        public uint GarrMissionSetID;
         public sbyte TargetLevel;
         public ushort TargetItemLevel;
         public int MissionDuration;
@@ -208,7 +208,7 @@ namespace Game.DataStorage
     {
         public uint Id;
         public string Name;
-        public sbyte PlotType;
+        public byte PlotType;
         public uint HordeConstructObjID;
         public uint AllianceConstructObjID;
         public byte Flags;
@@ -266,7 +266,7 @@ namespace Game.DataStorage
         public int GarrTalentTreeType;
         public int PlayerConditionID;
         public byte FeatureTypeIndex;
-        public sbyte FeatureSubtypeIndex;
+        public byte FeatureSubtypeIndex;
         public int CurrencyID;
     }
 
@@ -295,7 +295,7 @@ namespace Game.DataStorage
     {
         public uint Id;
         public uint SpellID;
-        public sbyte GlyphType;
+        public byte GlyphType;
         public byte GlyphExclusiveCategoryID;
         public uint SpellIconID;
     }

Source/Game/DataStorage/Structs/I_Records.cs

@@ -100,7 +100,7 @@ namespace Game.DataStorage
     public sealed class ItemBonusListGroupEntryRecord
     {
         public uint Id;
-        public int ItemBonusListGroupID;
+        public uint ItemBonusListGroupID;
         public int ItemBonusListID;
         public int ItemLevelSelectorID;
         public int SequenceValue;
@@ -133,7 +133,7 @@ namespace Game.DataStorage
     public sealed class ItemBonusTreeNodeRecord
     {
         public uint Id;
-        public sbyte ItemContext;
+        public byte ItemContext;
         public ushort ChildItemBonusTreeID;
         public ushort ChildItemBonusListID;
         public ushort ChildItemLevelSelectorID;
@@ -164,7 +164,7 @@ namespace Game.DataStorage
     public sealed class ItemContextPickerEntryRecord
     {
         public uint Id;
-        public sbyte ItemCreationContext;
+        public byte ItemCreationContext;
         public byte OrderIndex;
         public int PVal;
         public int LabelID;

Source/Game/DataStorage/Structs/L_Records.cs

@@ -29,7 +29,7 @@ namespace Game.DataStorage
         public LocalizedString Name;
         public string Description;
         public LfgType TypeID;
-        public sbyte Subtype;
+        public byte Subtype;
         public sbyte Faction;
         public int IconTextureFileID;
         public int RewardsBgTextureFileID;

Source/Game/DataStorage/Structs/M_Records.cs

@@ -164,7 +164,7 @@ namespace Game.DataStorage
     public sealed class MawPowerRecord
     {
         public uint Id;
-        public int SpellID;
+        public uint SpellID;
         public int MawPowerRarityID;
     }
 

Source/Game/DataStorage/Structs/P_Records.cs

@@ -106,7 +106,7 @@ namespace Game.DataStorage
         public sbyte ChrSpecializationRole;
         public uint ModifierTreeID;
         public sbyte PowerType;
-        public sbyte PowerTypeComp;
+        public byte PowerTypeComp;
         public byte PowerTypeValue;
         public int WeaponSubclassMask;
         public byte MaxGuildLevel;
@@ -230,7 +230,7 @@ namespace Game.DataStorage
     {
         public string Description;
         public uint Id;
-        public int SpecID;
+        public uint SpecID;
         public uint SpellID;
         public uint OverridesSpellID;
         public int Flags;
@@ -263,7 +263,7 @@ namespace Game.DataStorage
         public short MaxRating;
         public int PrevTier;
         public int NextTier;
-        public sbyte BracketID;
+        public byte BracketID;
         public sbyte Rank;
         public int RankIconFileDataID;
     }

Source/Game/DataStorage/Structs/S_Records.cs

@@ -122,7 +122,7 @@ namespace Game.DataStorage
     public sealed class SkillLineXTraitTreeRecord
     {
         public uint Id;
-        public int SkillLineID;
+        public uint SkillLineID;
         public int TraitTreeID;
         public int OrderIndex;
     }

Source/Game/DataStorage/Structs/T_Records.cs

@@ -112,7 +112,7 @@ namespace Game.DataStorage
     {
         public uint Id;
         public int CondType;
-        public int TraitTreeID;
+        public uint TraitTreeID;
         public int GrantedRanks;
         public uint QuestID;
         public uint AchievementID;
@@ -155,7 +155,7 @@ namespace Game.DataStorage
     {
         public LocalizedString Requirement;
         public uint Id;
-        public int TraitCurrencyID;
+        public uint TraitCurrencyID;
         public int Amount;
         public uint QuestID;
         public uint AchievementID;
@@ -179,7 +179,7 @@ namespace Game.DataStorage
     public sealed class TraitDefinitionEffectPointsRecord
     {
         public uint Id;
-        public int TraitDefinitionID;
+        public uint TraitDefinitionID;
         public int EffectIndex;
         public int OperationType;
         public int CurveID;
@@ -191,7 +191,7 @@ namespace Game.DataStorage
     {
         public uint Id;
         public int VisualStyle;
-        public int LeftTraitNodeID;
+        public uint LeftTraitNodeID;
         public int RightTraitNodeID;
         public int Type;
     }
@@ -199,7 +199,7 @@ namespace Game.DataStorage
     public sealed class TraitNodeRecord
     {
         public uint Id;
-        public int TraitTreeID;
+        public uint TraitTreeID;
         public int PosX;
         public int PosY;
         public byte Type;
@@ -224,20 +224,20 @@ namespace Game.DataStorage
     {
         public uint Id;
         public int TraitCondID;
-        public int TraitNodeEntryID;
+        public uint TraitNodeEntryID;
     }
 
     public sealed class TraitNodeEntryXTraitCostRecord
     {
         public uint Id;
-        public int TraitNodeEntryID;
+        public uint TraitNodeEntryID;
         public int TraitCostID;
     }
 
     public sealed class TraitNodeGroupRecord
     {
         public uint Id;
-        public int TraitTreeID;
+        public uint TraitTreeID;
         public int Flags;
     }
 
@@ -245,20 +245,20 @@ namespace Game.DataStorage
     {
         public uint Id;
         public int TraitCondID;
-        public int TraitNodeGroupID;
+        public uint TraitNodeGroupID;
     }
 
     public sealed class TraitNodeGroupXTraitCostRecord
     {
         public uint Id;
-        public int TraitNodeGroupID;
+        public uint TraitNodeGroupID;
         public int TraitCostID;
     }
 
     public sealed class TraitNodeGroupXTraitNodeRecord
     {
         public uint Id;
-        public int TraitNodeGroupID;
+        public uint TraitNodeGroupID;
         public int TraitNodeID;
         public int Index;
     }
@@ -267,20 +267,20 @@ namespace Game.DataStorage
     {
         public uint Id;
         public int TraitCondID;
-        public int TraitNodeID;
+        public uint TraitNodeID;
     }
 
     public sealed class TraitNodeXTraitCostRecord
     {
         public uint Id;
-        public int TraitNodeID;
+        public uint TraitNodeID;
         public int TraitCostID;
     }
 
     public sealed class TraitNodeXTraitNodeEntryRecord
     {
         public uint Id;
-        public int TraitNodeID;
+        public uint TraitNodeID;
         public int TraitNodeEntryID;
         public int Index;
     }
@@ -291,13 +291,13 @@ namespace Game.DataStorage
         public LocalizedString Description;
         public uint ID;
         public int UiTextureAtlasElementID;
-        public int TraitTreeID;             // Parent tree
+        public uint TraitTreeID;             // Parent tree
     }
 
     public sealed class TraitTreeRecord
     {
         public uint Id;
-        public int TraitSystemID;
+        public uint TraitSystemID;
         public int Unused1000_1;
         public int FirstTraitNodeID;
         public int PlayerConditionID;
@@ -311,14 +311,14 @@ namespace Game.DataStorage
     public sealed class TraitTreeLoadoutRecord
     {
         public uint Id;
-        public int TraitTreeID;
+        public uint TraitTreeID;
         public int ChrSpecializationID;
     }
 
     public sealed class TraitTreeLoadoutEntryRecord
     {
         public uint Id;
-        public int TraitTreeLoadoutID;
+        public uint TraitTreeLoadoutID;
         public int SelectedTraitNodeID;
         public int SelectedTraitNodeEntryID;
         public int NumPoints;
@@ -336,7 +336,7 @@ namespace Game.DataStorage
     {
         public uint Id;
         public int Index;
-        public int TraitTreeID;
+        public uint TraitTreeID;
         public int TraitCurrencyID;
     }
 
@@ -360,7 +360,7 @@ namespace Game.DataStorage
         public int Flags;
         public uint TransmogSetGroupID;
         public int ItemNameDescriptionID;
-        public int ParentTransmogSetID;
+        public uint ParentTransmogSetID;
         public int Unknown810;
         public int ExpansionID;
         public int PatchID;

Source/Game/DataStorage/Structs/U_Records.cs

@@ -10,9 +10,9 @@ namespace Game.DataStorage
     {
         public LocalizedString Name;
         public uint Id;
-        public int ParentUiMapID;
+        public uint ParentUiMapID;
         public int Flags;
-        public sbyte System;
+        public byte System;
         public UiMapType Type;
         public int BountySetID;
         public uint BountyDisplayLocation;
@@ -34,7 +34,7 @@ namespace Game.DataStorage
         public Vector2 UiMax;
         public Vector3[] Region = new Vector3[2];
         public uint Id;
-        public int UiMapID;
+        public uint UiMapID;
         public int OrderIndex;
         public int MapID;
         public int AreaID;
@@ -47,7 +47,7 @@ namespace Game.DataStorage
         public Vector2 UiMin;
         public Vector2 UiMax;
         public uint Id;
-        public int ParentUiMapID;
+        public uint ParentUiMapID;
         public int OrderIndex;
         public int ChildUiMapID;
         public int PlayerConditionID;
@@ -76,7 +76,7 @@ namespace Game.DataStorage
         public string RightFeatureDesc;
         public int AllianceQuestID;
         public int HordeQuestID;
-        public sbyte ScreenType;
+        public byte ScreenType;
         public int TextureKitID;
         public int SoundKitID;
         public int PlayerConditionID;