Core/DataStores: Removed overriding field sign type based on db2 column compression

Port From (https://github.com/TrinityCore/TrinityCore/commit/89f490bdcdf88c2576c17218926e89b1082ae682)

Source/Game/Entities/Conversation.cs

@@ -146,7 +146,7 @@ namespace Game.Entities
                     if (locale == Locale.enUS)
                         lineField.StartTime = (uint)_lastLineEndTimes[(int)locale].TotalMilliseconds;
 
-                    int broadcastTextDuration = Global.DB2Mgr.GetBroadcastTextDuration((int)convoLine.BroadcastTextID, locale);
+                    int broadcastTextDuration = Global.DB2Mgr.GetBroadcastTextDuration(convoLine.BroadcastTextID, locale);
                     if (broadcastTextDuration != 0)
                         _lastLineEndTimes[(int)locale] += TimeSpan.FromMilliseconds(broadcastTextDuration);
 
@@ -236,7 +236,7 @@ namespace Game.Entities
                 return 0;
             }
 
-            int textDuration = Global.DB2Mgr.GetBroadcastTextDuration((int)convoLine.BroadcastTextID, locale);
+            int textDuration = Global.DB2Mgr.GetBroadcastTextDuration(convoLine.BroadcastTextID, locale);
             if (textDuration == 0)
                 return 0;
 

Source/Game/Entities/Item/AzeriteEmpoweredItem.cs

@@ -224,7 +224,7 @@ namespace Game.Entities
         {
             m_azeritePowers = Global.DB2Mgr.GetAzeritePowers(GetEntry());
             if (m_azeritePowers != null)
-                m_maxTier = m_azeritePowers.Aggregate((a1, a2) => a1.Tier < a2.Tier ? a2 : a1).Tier;
+                m_maxTier = m_azeritePowers.Max(p => p.Tier);
         }
 
         public int GetMaxAzeritePowerTier() { return m_maxTier; }

Source/Game/Entities/Item/ItemBonusManager.cs

@@ -15,7 +15,7 @@ namespace Game.Entities
         static MultiMap<uint /*azeriteUnlockMappingSetId*/, AzeriteUnlockMappingRecord> _azeriteUnlockMappings = new();
         static MultiMap<uint /*itemBonusTreeId*/, ChallengeModeItemBonusOverrideRecord> _challengeModeItemBonusOverrides = new();
         static MultiMap<uint /*itemBonusListId*/, ItemBonusRecord> _itemBonusLists = new();
-        static MultiMap<int, ItemBonusListGroupEntryRecord> _itemBonusListGroupEntries = new();
+        static MultiMap<uint, ItemBonusListGroupEntryRecord> _itemBonusListGroupEntries = new();
         static Dictionary<short /*itemLevelDelta*/, uint /*itemBonusListId*/> _itemLevelDeltaToBonusListContainer = new();
         static SortedMultiMap<uint /*itemLevelSelectorQualitySetId*/, ItemLevelSelectorQualityRecord> _itemLevelQualitySelectorQualities = new();
         static MultiMap<uint /*itemBonusTreeId*/, ItemBonusTreeNodeRecord> _itemBonusTrees = new();

Source/Game/Entities/Object/Update/UpdateFields.cs

@@ -4348,7 +4348,7 @@ namespace Game.Entities
         public UpdateField<int> ChrSpecializationID = new(8, 9);
         public UpdateField<int> CombatConfigFlags = new(8, 10);
         public UpdateField<int> LocalIdentifier = new(8, 11);
-        public UpdateField<int> TraitSystemID = new(12, 13);
+        public UpdateField<uint> TraitSystemID = new(12, 13);
 
         public TraitConfig() : base(14) { }
 
@@ -4370,7 +4370,7 @@ namespace Game.Entities
             }
             if (Type == 3)
             {
-                data.WriteInt32(TraitSystemID);
+                data.WriteUInt32(TraitSystemID);
             }
             for (int i = 0; i < Entries.Size(); ++i)
             {
@@ -4482,7 +4482,7 @@ namespace Game.Entities
                 {
                     if (Type == 3)
                     {
-                        data.WriteInt32(TraitSystemID);
+                        data.WriteUInt32(TraitSystemID);
                     }
                 }
             }

Source/Game/Entities/Player/Player.DB.cs

@@ -1095,7 +1095,7 @@ namespace Game.Entities
                             traitConfig.SkillLineID = configsResult.Read<uint>(5);
                             break;
                         case TraitConfigType.Generic:
-                            traitConfig.TraitSystemID = configsResult.Read<int>(6);
+                            traitConfig.TraitSystemID = configsResult.Read<uint>(6);
                             break;
                         default:
                             break;

Source/Game/Entities/Taxi/TaxiPathGraph.cs

@@ -17,7 +17,7 @@ namespace Game.Entities
         static List<TaxiNodesRecord> m_nodesByVertex = new();
         static Dictionary<uint, uint> m_verticesByNode = new();
 
-        static void GetTaxiMapPosition(Vector3 position, int mapId, out Vector2 uiMapPosition, out int uiMapId)
+        static void GetTaxiMapPosition(Vector3 position, int mapId, out Vector2 uiMapPosition, out uint uiMapId)
         {
             if (!Global.DB2Mgr.GetUiMapPosition(position.X, position.Y, position.Z, mapId, 0, 0, 0, UiMapSystem.Adventure, false, out uiMapId, out uiMapPosition))
                 Global.DB2Mgr.GetUiMapPosition(position.X, position.Y, position.Z, mapId, 0, 0, 0, UiMapSystem.Taxi, false, out uiMapId, out uiMapPosition);
@@ -62,7 +62,7 @@ namespace Game.Entities
                     if (nodes[i - 1].HasFlag(TaxiPathNodeFlags.Teleport))
                         continue;
 
-                    int uiMap1, uiMap2;
+                    uint uiMap1, uiMap2;
                     Vector2 pos1, pos2;
 
                     GetTaxiMapPosition(nodes[i - 1].Loc, nodes[i - 1].ContinentID, out pos1, out uiMap1);