Core/Spells: Rename SpellAttr4 to use official attribute names

Port From (https://github.com/TrinityCore/TrinityCore/commit/8d16a79dea4c0100d36e13b068c42499a3a48154)

Source/Game/Spells/SpellInfo.cs

@@ -580,7 +580,7 @@ namespace Game.Spells
 
         public bool HasInitialAggro()
         {
-            return !(HasAttribute(SpellAttr1.NoThreat) || HasAttribute(SpellAttr2.NoInitialThreat));
+            return !(HasAttribute(SpellAttr1.NoThreat) || HasAttribute(SpellAttr2.NoInitialThreat) || HasAttribute(SpellAttr4.NoHarmfulThreat));
         }
 
         public bool HasHitDelay()
@@ -858,7 +858,7 @@ namespace Game.Spells
             }
 
             // continent limitation (virtual continent)
-            if (HasAttribute(SpellAttr4.CastOnlyInOutland))
+            if (HasAttribute(SpellAttr4.OnlyFlyingAreas))
             {
                 uint mountFlags = 0;
                 if (player && player.HasAuraType(AuraType.MountRestrictions))
@@ -2859,7 +2859,7 @@ namespace Game.Spells
             bool initiallyNegative = powerCost < 0;
 
             // Shiv - costs 20 + weaponSpeed*10 energy (apply only to non-triggered spell with energy cost)
-            if (HasAttribute(SpellAttr4.SpellVsExtendCost))
+            if (HasAttribute(SpellAttr4.WeaponSpeedCostScaling))
             {
                 uint speed = 0;
                 SpellShapeshiftFormRecord ss = CliDB.SpellShapeshiftFormStorage.LookupByKey(unitCaster.GetShapeshiftForm());
@@ -3323,6 +3323,9 @@ namespace Game.Spells
             if (spellInfo.HasAttribute(SpellAttr0.AuraIsDebuff))
                 return false;
 
+            if (spellInfo.HasAttribute(SpellAttr4.AuraIsBuff))
+                return true;
+
             visited.Add(Tuple.Create(spellInfo, effect.EffectIndex));
 
             //We need scaling level info for some auras that compute bp 0 or positive but should be debuffs