Inna/CypherCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Core/Entities: completely remove 60% melee miss cap as there is no proof of its existence

Browse Source 
Port From (https://github.com/TrinityCore/TrinityCore/commit/a6e84ebfabdaef50c9e0039dea4ec52b88827b26)
This commit is contained in:
hondacrx
2021-09-09 13:55:36 -04:00
parent 6e9d1ba1f7
commit 647aca03c2
2 changed files with 4 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/Game/Entities/StatSystem.cs
+4 -8
View File
@@ -813,10 +813,8 @@ namespace Game.Entities
else else
missChance -= ModMeleeHitChance; missChance -= ModMeleeHitChance;
// Limit miss chance to 60% // miss chance from auras after calculating skill based miss
missChance = Math.Min(missChance, 60f); missChance -= GetTotalAuraModifier(AuraType.ModHitChance);
// miss chance from SPELL_AURA_MOD_ATTACKER_xxx_HIT_CHANCE can exceed 60% miss cap (eg aura 50240)
if (attType == WeaponAttackType.RangedAttack) if (attType == WeaponAttackType.RangedAttack)
missChance -= victim.GetTotalAuraModifier(AuraType.ModAttackerRangedHitChance); missChance -= victim.GetTotalAuraModifier(AuraType.ModAttackerRangedHitChance);
else else
@@ -1885,14 +1883,12 @@ namespace Game.Entities
public void UpdateMeleeHitChances() public void UpdateMeleeHitChances()
{ {
ModMeleeHitChance = 7.5f + GetTotalAuraModifier(AuraType.ModHitChance); ModMeleeHitChance = 7.5f + GetRatingBonusValue(CombatRating.HitMelee);
ModMeleeHitChance += GetRatingBonusValue(CombatRating.HitMelee);
} }
public void UpdateRangedHitChances() public void UpdateRangedHitChances()
{ {
ModRangedHitChance = 7.5f + GetTotalAuraModifier(AuraType.ModHitChance); ModRangedHitChance = 7.5f + GetRatingBonusValue(CombatRating.HitRanged);
ModRangedHitChance += GetRatingBonusValue(CombatRating.HitRanged);
} }
public void UpdateSpellHitChances() public void UpdateSpellHitChances()
Source/Game/Spells/Auras/AuraEffect.cs
-22
View File
@@ -3609,28 +3609,6 @@ namespace Game.Spells
target.UpdateAllWeaponDependentCritAuras(); target.UpdateAllWeaponDependentCritAuras();
} }
[AuraEffectHandler(AuraType.ModHitChance)]
void HandleModHitChance(AuraApplication aurApp, AuraEffectHandleModes mode, bool apply)
{
if (!mode.HasAnyFlag((AuraEffectHandleModes.ChangeAmountMask | AuraEffectHandleModes.Stat)))
return;
Unit target = aurApp.GetTarget();
// handle stack rules
if (target.IsTypeId(TypeId.Player))
{
target.ToPlayer().UpdateMeleeHitChances();
target.ToPlayer().UpdateRangedHitChances();
}
else
{
float value = target.GetTotalAuraModifier(AuraType.ModHitChance);
target.ModMeleeHitChance = value;
target.ModRangedHitChance = value;
}
}
[AuraEffectHandler(AuraType.ModSpellHitChance)] [AuraEffectHandler(AuraType.ModSpellHitChance)]
void HandleModSpellHitChance(AuraApplication aurApp, AuraEffectHandleModes mode, bool apply) void HandleModSpellHitChance(AuraApplication aurApp, AuraEffectHandleModes mode, bool apply)
{ {