Inna/CypherCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Core/Misc: Remove extremely forgettable tiny utility function

Browse Source 
Port From (https://github.com/TrinityCore/TrinityCore/commit/6502efbae802c2164c80769ff4c5389e4142d3b6)
This commit is contained in:
Hondacrx
2025-08-18 10:50:56 -04:00
parent c0ffaa659b
commit 6995976f3c
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/Game/Movement/Generators/ChaseMovementGenerator.cs
+2 -3
View File
@@ -251,10 +251,9 @@ namespace Game.Movement
static bool PositionOkay(Unit owner, Unit target, float? minDistance, float? maxDistance, ChaseAngle? angle) static bool PositionOkay(Unit owner, Unit target, float? minDistance, float? maxDistance, ChaseAngle? angle)
{ {
float distSq = owner.GetExactDistSq(target); if (minDistance .HasValue && owner.IsInDist(target, minDistance.Value))
if (minDistance.HasValue && distSq < minDistance.Value * minDistance.Value)
return false; return false;
if (maxDistance.HasValue && distSq > maxDistance.Value * maxDistance.Value) if (maxDistance.HasValue && !owner.IsInDist(target, maxDistance.Value))
return false; return false;
if (angle.HasValue && !angle.Value.IsAngleOkay(target.GetRelativeAngle(owner))) if (angle.HasValue && !angle.Value.IsAngleOkay(target.GetRelativeAngle(owner)))
return false; return false;
Source/Game/Movement/Generators/FollowMovementGenerator.cs
+1 -1
View File
@@ -222,7 +222,7 @@ namespace Game.Movement
static bool PositionOkay(Unit owner, Unit target, float range, ChaseAngle? angle = null) static bool PositionOkay(Unit owner, Unit target, float range, ChaseAngle? angle = null)
{ {
if (owner.GetExactDistSq(target) > (owner.GetCombatReach() + target.GetCombatReach() + range) * (owner.GetCombatReach() + target.GetCombatReach() + range)) if (!owner.IsInDist(target, owner.GetCombatReach() + target.GetCombatReach() + range))
return false; return false;
return !angle.HasValue || angle.Value.IsAngleOkay(target.GetRelativeAngle(owner)); return !angle.HasValue || angle.Value.IsAngleOkay(target.GetRelativeAngle(owner));