Core/Errors: Stop using System.Diagnostics.Contracts, Its just closing the server without error or warning. We now log the error and then throw a exception

This commit is contained in:
hondacrx
2018-06-15 12:34:56 -04:00
parent 1289bc3ed1
commit 7aa494d5dd
86 changed files with 520 additions and 558 deletions
+1 -2
View File
@@ -21,7 +21,6 @@ using Game.Entities;
using Game.Network;
using Game.Network.Packets;
using System;
using System.Diagnostics.Contracts;
namespace Game
{
@@ -52,7 +51,7 @@ namespace Game
if (vehicle)
{
VehicleSeatRecord seat = vehicle.GetSeatForPassenger(GetPlayer());
Contract.Assert(seat != null);
Cypher.Assert(seat != null);
if (!seat.Flags.HasAnyFlag(VehicleSeatFlags.CanAttack))
{
SendAttackStop(enemy);
+2 -3
View File
@@ -20,7 +20,6 @@ using Game.Entities;
using Game.Groups;
using Game.Network;
using Game.Network.Packets;
using System.Diagnostics.Contracts;
namespace Game
{
@@ -204,7 +203,7 @@ namespace Game
}
// If we're about to create a group there really should be a leader present
Contract.Assert(leader);
Cypher.Assert(leader);
group.RemoveInvite(leader);
group.Create(leader);
Global.GroupMgr.AddGroup(group);
@@ -253,7 +252,7 @@ namespace Game
Group grp = GetPlayer().GetGroup();
// grp is checked already above in CanUninviteFromGroup()
Contract.Assert(grp);
Cypher.Assert(grp);
if (grp.IsMember(packet.TargetGUID))
{
+1 -2
View File
@@ -22,7 +22,6 @@ using Game.Network;
using Game.Network.Packets;
using Game.Spells;
using System.Collections.Generic;
using System.Diagnostics.Contracts;
namespace Game
{
@@ -231,7 +230,7 @@ namespace Game
GetPlayer().StopCastingCharm();
else if (pet.GetOwnerGUID() == GetPlayer().GetGUID())
{
Contract.Assert(pet.IsTypeId(TypeId.Unit));
Cypher.Assert(pet.IsTypeId(TypeId.Unit));
if (pet.IsPet())
{
if (pet.ToPet().getPetType() == PetType.Hunter)
+1 -2
View File
@@ -20,7 +20,6 @@ using Game.DataStorage;
using Game.Entities;
using Game.Network;
using Game.Network.Packets;
using System.Diagnostics.Contracts;
namespace Game
{
@@ -185,7 +184,7 @@ namespace Game
}
VehicleSeatRecord seat = vehicle.GetSeatForPassenger(unit);
Contract.Assert(seat != null);
Cypher.Assert(seat != null);
if (seat.IsEjectable())
unit.ExitVehicle();
else