Core/Creatures: Move immunities to separate table and implemented setting immunties to dispel, spell effects, aura types, aoe and chain targeting

Port From (https://github.com/TrinityCore/TrinityCore/commit/f70a5817e1c07891185d716611d45f50b1c73b78)

Source/Game/Entities/Creature/Creature.Fields.cs

@@ -29,6 +29,7 @@ namespace Game.Entities
 
         bool _isMissingCanSwimFlagOutOfCombat;
 
+        int _creatureImmunitiesId;
         uint _gossipMenuId;
         uint? _trainerId;
         float _sparringHealthPct;

Source/Game/Entities/Creature/Creature.cs

@@ -397,7 +397,7 @@ namespace Game.Entities
 
             LoadCreaturesAddon();
             LoadCreaturesSparringHealth();
-            LoadTemplateImmunities();
+            LoadTemplateImmunities(cInfo.CreatureImmunitiesId);
             GetThreatManager().EvaluateSuppressed();
 
             //We must update last scriptId or it looks like we reloaded a script, breaking some things such as gossip temporarily
@@ -2177,38 +2177,47 @@ namespace Game.Entities
                 ForcedDespawn((uint)msTimeToDespawn.TotalMilliseconds, forceRespawnTimer);
         }
 
-        public void LoadTemplateImmunities()
+        public void LoadTemplateImmunities(int creatureImmunitiesId)
         {
             // uint32 max used for "spell id", the immunity system will not perform SpellInfo checks against invalid spells
             // used so we know which immunities were loaded from template
             uint placeholderSpellId = uint.MaxValue;
 
-            // unapply template immunities (in case we're updating entry)
-            for (uint i = 0; i < (int)Mechanics.Max; ++i)
-                ApplySpellImmune(placeholderSpellId, SpellImmunity.Mechanic, i, false);
-
-            for (var i = (int)SpellSchools.Normal; i < (int)SpellSchools.Max; ++i)
-                ApplySpellImmune(placeholderSpellId, SpellImmunity.School, 1u << i, false);
-
-            // don't inherit immunities for hunter pets
-            if (GetOwnerGUID().IsPlayer() && IsHunterPet())
-                return;
-
-            ulong mechanicMask = GetCreatureTemplate().MechanicImmuneMask;
-            if (mechanicMask != 0)
+            void applyCreatureImmunities(CreatureImmunities immunities, bool apply)
             {
-                for (uint i = 0 + 1; i < (int)Mechanics.Max; ++i)
-                {
-                    if ((mechanicMask & (1ul << ((int)i - 1))) != 0)
-                        ApplySpellImmune(placeholderSpellId, SpellImmunity.Mechanic, i, true);
-                }
+                for (var i = 0; i < immunities.School.Count; ++i)
+                    if (immunities.School[i])
+                        ApplySpellImmune(placeholderSpellId, SpellImmunity.School, 1u << i, apply);
+
+                for (int i = 0; i < immunities.DispelType.Count; ++i)
+                    if (immunities.DispelType[i])
+                        ApplySpellImmune(placeholderSpellId, SpellImmunity.Dispel, (uint)i, apply);
+
+                for (var i = 0; i < immunities.Mechanic.Count; ++i)
+                    if (immunities.Mechanic[i])
+                        ApplySpellImmune(placeholderSpellId, SpellImmunity.Mechanic, (uint)i, apply);
+
+                foreach (SpellEffectName effect in immunities.Effect)
+                    ApplySpellImmune(placeholderSpellId, SpellImmunity.Effect, effect, apply);
+
+                foreach (AuraType aura in immunities.Aura)
+                    ApplySpellImmune(placeholderSpellId, SpellImmunity.State, aura, apply);
             }
 
-            uint schoolMask = GetCreatureTemplate().SpellSchoolImmuneMask;
-            if (schoolMask != 0)
-                for (var i = (int)SpellSchools.Normal; i <= (int)SpellSchools.Max; ++i)
-                    if ((schoolMask & (1 << i)) != 0)
-                        ApplySpellImmune(placeholderSpellId, SpellImmunity.School, 1u << i, true);
+            // unapply template immunities (in case we're updating entry)
+            CreatureImmunities immunities = Global.SpellMgr.GetCreatureImmunities(_creatureImmunitiesId);
+            if (immunities != null)
+                applyCreatureImmunities(immunities, false);
+
+            // apply new immunities
+            immunities = Global.SpellMgr.GetCreatureImmunities(creatureImmunitiesId);
+            if (immunities != null)
+            {
+                _creatureImmunitiesId = creatureImmunitiesId;
+                applyCreatureImmunities(immunities, true);
+            }
+            else
+                _creatureImmunitiesId = 0;
         }
 
         public override bool IsImmunedToSpellEffect(SpellInfo spellInfo, SpellEffectInfo spellEffectInfo, WorldObject caster, bool requireImmunityPurgesEffectAttribute = false)

Source/Game/Entities/Creature/CreatureData.cs

@@ -55,8 +55,7 @@ namespace Game.Entities
         public int WidgetSetID;
         public int WidgetSetUnitConditionID;
         public bool RegenHealth;
-        public ulong MechanicImmuneMask;
-        public uint SpellSchoolImmuneMask;
+        public int CreatureImmunitiesId;
         public CreatureFlagsExtra FlagsExtra;
         public uint ScriptID;
         public string StringId;

Source/Game/Entities/Pet.cs

@@ -370,7 +370,7 @@ namespace Game.Entities
                         owner.DisablePetControlsOnMount(ReactStates.Passive, CommandStates.Follow);
 
                     // must be after SetMinion (owner guid check)
-                    LoadTemplateImmunities();
+                    LoadTemplateImmunities(0);
                     m_loading = false;
                 });
 

Source/Game/Entities/Unit/Unit.Movement.cs

@@ -562,8 +562,8 @@ namespace Game.Entities
                         Creature creature1 = ToCreature();
                         if (creature1 != null)
                         {
-                            ulong immuneMask = creature1.GetCreatureTemplate().MechanicImmuneMask;
-                            if (Convert.ToBoolean(immuneMask & (1 << ((int)Mechanics.Snare - 1))) || Convert.ToBoolean(immuneMask & (1 << ((int)Mechanics.Daze - 1))))
+                            CreatureImmunities immunities = Global.SpellMgr.GetCreatureImmunities(creature1.GetCreatureTemplate().CreatureImmunitiesId);
+                            if (immunities != null && (immunities.Mechanic[(int)Mechanics.Snare] || immunities.Mechanic[(int)Mechanics.Daze]))
                                 break;
                         }