Replace most T.Parse with T.TryParse for all user input.
This commit is contained in:
@@ -284,8 +284,10 @@ namespace Game.Entities
|
||||
var GUIDlist = new StringArray(strGUID, ' ');
|
||||
List<ObjectGuid> looters = new List<ObjectGuid>();
|
||||
for (var i = 0; i < GUIDlist.Length; ++i)
|
||||
looters.Add(ObjectGuid.Create(HighGuid.Item, ulong.Parse(GUIDlist[i])));
|
||||
|
||||
{
|
||||
if (ulong.TryParse(GUIDlist[i], out ulong guid))
|
||||
looters.Add(ObjectGuid.Create(HighGuid.Item, guid));
|
||||
}
|
||||
|
||||
if (looters.Count > 1 && item.GetTemplate().GetMaxStackSize() == 1 && item.IsSoulBound())
|
||||
{
|
||||
@@ -1083,7 +1085,10 @@ namespace Game.Entities
|
||||
List<uint> bonusListIDs = new List<uint>();
|
||||
var bonusListIdTokens = new StringArray(result.Read<string>(11), ' ');
|
||||
for (var i = 0; i < bonusListIdTokens.Length; ++i)
|
||||
bonusListIDs.Add(uint.Parse(bonusListIdTokens[i]));
|
||||
{
|
||||
if (uint.TryParse(bonusListIdTokens[i], out uint id))
|
||||
bonusListIDs.Add(id);
|
||||
}
|
||||
|
||||
if (itemId == 0)
|
||||
{
|
||||
|
||||
@@ -109,7 +109,8 @@ namespace Game.Entities
|
||||
for (var i = 0; index < PlayerConst.TaxiMaskSize && i != split.Length; ++i, ++index)
|
||||
{
|
||||
// load and set bits only for existing taxi nodes
|
||||
m_taximask[index] = (byte)(CliDB.TaxiNodesMask[index] & uint.Parse(split[i]));
|
||||
if (uint.TryParse(split[i], out uint id))
|
||||
m_taximask[index] = (byte)(CliDB.TaxiNodesMask[index] & id);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -127,12 +128,12 @@ namespace Game.Entities
|
||||
|
||||
var stringArray = new StringArray(values, ' ');
|
||||
if (stringArray.Length > 0)
|
||||
m_flightMasterFactionId = uint.Parse(stringArray[0]);
|
||||
uint.TryParse(stringArray[0], out m_flightMasterFactionId);
|
||||
|
||||
for (var i = 1; i < stringArray.Length; ++i)
|
||||
{
|
||||
uint node = uint.Parse(stringArray[i]);
|
||||
AddTaxiDestination(node);
|
||||
if (uint.TryParse(stringArray[i], out uint node))
|
||||
AddTaxiDestination(node);
|
||||
}
|
||||
|
||||
if (m_TaxiDestinations.Empty())
|
||||
|
||||
Reference in New Issue
Block a user