Core/Spells: rework part 1: Improved positive detection logic

Port From (https://github.com/TrinityCore/TrinityCore/commit/1e1415a49128d034c8d48aa8cbb5d157200371b0)
2021-08-28 13:56:32 -04:00
parent e35094f0a3
commit 9123dec4b9
3 changed files with 404 additions and 217 deletions
@@ -2281,7 +2281,8 @@ namespace Game.Spells
                        {
                            for (uint i = 0; i < SpellConst.MaxEffects; ++i)
                            {
-                                if ((effectMask & (1 << (int)i)) != 0 && !m_spellInfo.IsPositiveEffect(i))
+                                // mod duration only for effects applying aura!
+                                if ((aura_effmask & (1 << (int)i)) != 0 && !m_spellInfo.IsPositiveEffect(i))
                                {
                                    positive = false;
                                    break;