Core/BattlePets: Fix using moved-from variable when adding new pet

Port From (https://github.com/TrinityCore/TrinityCore/commit/f58a5fe67430eac922a309b244eff7a396aa0adc)
This commit is contained in:
Hondacrx
2025-08-25 22:05:35 -04:00
parent 38d54703d5
commit 94e60194ae
+4 -5
View File
@@ -391,17 +391,16 @@ namespace Game.BattlePets
if (!battlePetSpecies.HasFlag(BattlePetSpeciesFlags.WellKnown)) // Not learnable if (!battlePetSpecies.HasFlag(BattlePetSpeciesFlags.WellKnown)) // Not learnable
return; return;
ObjectGuid guid = ObjectGuid.Create(HighGuid.BattlePet, Global.ObjectMgr.GetGenerator(HighGuid.BattlePet).Generate());
BattlePet pet = new(); BattlePet pet = new();
pet.PacketInfo.Guid = ObjectGuid.Create(HighGuid.BattlePet, Global.ObjectMgr.GetGenerator(HighGuid.BattlePet).Generate()); pet.PacketInfo.Guid = guid;
pet.PacketInfo.Species = species; pet.PacketInfo.Species = species;
pet.PacketInfo.CreatureID = battlePetSpecies.CreatureID; pet.PacketInfo.CreatureID = battlePetSpecies.CreatureID;
pet.PacketInfo.DisplayID = display; pet.PacketInfo.DisplayID = display;
pet.PacketInfo.Level = level; pet.PacketInfo.Level = level;
pet.PacketInfo.Exp = 0;
pet.PacketInfo.Flags = 0;
pet.PacketInfo.Breed = breed; pet.PacketInfo.Breed = breed;
pet.PacketInfo.Quality = (byte)quality; pet.PacketInfo.Quality = (byte)quality;
pet.PacketInfo.Name = "";
pet.CalculateStats(); pet.CalculateStats();
pet.PacketInfo.Health = pet.PacketInfo.MaxHealth; pet.PacketInfo.Health = pet.PacketInfo.MaxHealth;
@@ -417,7 +416,7 @@ namespace Game.BattlePets
pet.SaveInfo = BattlePetSaveInfo.New; pet.SaveInfo = BattlePetSaveInfo.New;
_pets[pet.PacketInfo.Guid.GetCounter()] = pet; _pets[guid.GetCounter()] = pet;
List<BattlePet> updates = [pet]; List<BattlePet> updates = [pet];
SendUpdates(updates, true); SendUpdates(updates, true);