From a862056cc4f61559070d810924ae724fba919c3a Mon Sep 17 00:00:00 2001 From: hondacrx Date: Thu, 14 Sep 2023 04:30:42 -0400 Subject: [PATCH] Core/Spells: Prevent rerolling gathering skillups until success when mining or gathering herbs Port From (https://github.com/TrinityCore/TrinityCore/commit/dce71612efa11bad7f25c65962d455843bd79baf) --- Source/Game/Spells/SpellEffects.cs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Source/Game/Spells/SpellEffects.cs b/Source/Game/Spells/SpellEffects.cs index ce3f330f9..b6b9fbc3f 100644 --- a/Source/Game/Spells/SpellEffects.cs +++ b/Source/Game/Spells/SpellEffects.cs @@ -1309,9 +1309,11 @@ namespace Game.Spells if (gameObjTarget != null) { // Allow one skill-up until respawned - if (!gameObjTarget.IsInSkillupList(player.GetGUID()) && - player.UpdateGatherSkill(skillId, pureSkillValue, (uint)reqSkillValue, 1, gameObjTarget)) + if (!gameObjTarget.IsInSkillupList(player.GetGUID())) + { + player.UpdateGatherSkill((uint)skillId, pureSkillValue, (uint)reqSkillValue, 1, gameObjTarget); gameObjTarget.AddToSkillupList(player.GetGUID()); + } } else if (itemTarget != null) {