Inna/CypherCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Core/SAI: Reduce the chance of infinite loops/stack overflows

Browse Source 
Port From (https://github.com/TrinityCore/TrinityCore/commit/4dff5bd09b73c0a02cf8a95f9e4f528e74a5ef50)
This commit is contained in:
hondacrx
2022-04-28 10:11:23 -04:00
parent 6bf9affe8e
commit ac388f2a1a
1 changed files with 24 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/Game/AI/SmartScripts/SmartScript.cs
+24 -8
View File
@@ -32,6 +32,9 @@ namespace Game.AI
{
public class SmartScript
{
// Max number of nested ProcessEventsFor() calls to avoid infinite loops
const uint MaxNestedEvents = 10;
public ObjectGuid LastInvoker;
Dictionary<uint, uint> _counterList = new();
@@ -63,6 +66,7 @@ namespace Game.AI
bool _useTextTimer;
uint _currentPriority;
bool _eventSortingRequired;
uint _nestedEventsCounter;
Dictionary<uint, ObjectGuidList> _storedTargets = new();
@@ -111,16 +115,28 @@ namespace Game.AI
public void ProcessEventsFor(SmartEvents e, Unit unit = null, uint var0 = 0, uint var1 = 0, bool bvar = false, SpellInfo spell = null, GameObject gob = null, string varString = "")
{
foreach (var Event in _events)
{
SmartEvents eventType = Event.GetEventType();
if (eventType == SmartEvents.Link)//special handling
continue;
_nestedEventsCounter++;
if (eventType == e)
if (Global.ConditionMgr.IsObjectMeetingSmartEventConditions(Event.EntryOrGuid, Event.EventId, Event.SourceType, unit, GetBaseObject()))
ProcessEvent(Event, unit, var0, var1, bvar, spell, gob, varString);
// Allow only a fixed number of nested ProcessEventsFor calls
if (_nestedEventsCounter > MaxNestedEvents)
{
Log.outWarn(LogFilter.ScriptsAi, $"SmartScript::ProcessEventsFor: reached the limit of max allowed nested ProcessEventsFor() calls with event {e}, skipping!\n{GetBaseObject().GetDebugInfo()}");
}
else
{
foreach (var Event in _events)
{
SmartEvents eventType = Event.GetEventType();
if (eventType == SmartEvents.Link)//special handling
continue;
if (eventType == e)
if (Global.ConditionMgr.IsObjectMeetingSmartEventConditions(Event.EntryOrGuid, Event.EventId, Event.SourceType, unit, GetBaseObject()))
ProcessEvent(Event, unit, var0, var1, bvar, spell, gob, varString);
}
}
--mNestedEventsCounter;
}
void ProcessAction(SmartScriptHolder e, Unit unit = null, uint var0 = 0, uint var1 = 0, bool bvar = false, SpellInfo spell = null, GameObject gob = null, string varString = "")