From b66d65d406f87b276fd56bbaa60b2b2d1d0bcdf2 Mon Sep 17 00:00:00 2001 From: hondacrx Date: Sun, 29 Aug 2021 18:28:48 -0400 Subject: [PATCH] Core/Reputation: Fixed FriendshipReputationFlags::NoRepGainModifiers implementation Port From (https://github.com/TrinityCore/TrinityCore/commit/b9647bdecc08e63041bbf0d845d5c5b81705e180) --- Source/Game/Entities/Player/Player.cs | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/Source/Game/Entities/Player/Player.cs b/Source/Game/Entities/Player/Player.cs index b8b62bfe2..07e0600ed 100644 --- a/Source/Game/Entities/Player/Player.cs +++ b/Source/Game/Entities/Player/Player.cs @@ -1425,13 +1425,16 @@ namespace Game.Entities float percent = 100.0f; - float repMod = noQuestBonus ? 0.0f : GetTotalAuraModifier(AuraType.ModReputationGain); + if (!noBonuses) + { + float repMod = noQuestBonus ? 0.0f : GetTotalAuraModifier(AuraType.ModReputationGain); - // faction specific auras only seem to apply to kills - if (source == ReputationSource.Kill) - repMod += GetTotalAuraModifierByMiscValue(AuraType.ModFactionReputationGain, faction); + // faction specific auras only seem to apply to kills + if (source == ReputationSource.Kill) + repMod += GetTotalAuraModifierByMiscValue(AuraType.ModFactionReputationGain, faction); - percent += rep > 0 ? repMod : -repMod; + percent += rep > 0 ? repMod : -repMod; + } float rate; switch (source)