From ba6951c11dbe4bfe047ce6af5314f2cc88a5e371 Mon Sep 17 00:00:00 2001 From: hondacrx Date: Wed, 6 May 2020 13:43:42 -0400 Subject: [PATCH] Core/AchievementMgr: fix integer underflow neglecting already completed realm firsts Port From (https://github.com/TrinityCore/TrinityCore/commit/786bb561ca8b92033b962321d998fa2266f6e529) --- Source/Game/Achievements/AchievementManager.cs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Source/Game/Achievements/AchievementManager.cs b/Source/Game/Achievements/AchievementManager.cs index 0614bfba8..e5a98889a 100644 --- a/Source/Game/Achievements/AchievementManager.cs +++ b/Source/Game/Achievements/AchievementManager.cs @@ -1058,6 +1058,9 @@ namespace Game.Achievements if (time == DateTime.MinValue) return false; + if (time == DateTime.MaxValue) + return true; + // Allow completing the realm first kill for entire minute after first person did it // it may allow more than one group to achieve it (highly unlikely) // but apparently this is how blizz handles it as well