From c1fb79b0862ee73a97a719e3c753096981619210 Mon Sep 17 00:00:00 2001 From: hondacrx Date: Mon, 29 Mar 2021 16:06:26 -0400 Subject: [PATCH] Core/Auras: Corrected logic used to determine if a spellmod should affect another spell, empty family name or class mask should not apply to any spell Port From (https://github.com/TrinityCore/TrinityCore/commit/3f479399695ce4aed7f508be46cfdccfd4353eee) --- Source/Game/Spells/SpellInfo.cs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Source/Game/Spells/SpellInfo.cs b/Source/Game/Spells/SpellInfo.cs index b94c06293..3c37d178f 100644 --- a/Source/Game/Spells/SpellInfo.cs +++ b/Source/Game/Spells/SpellInfo.cs @@ -668,7 +668,9 @@ namespace Game.Spells if (affectSpell == null) return false; - return IsAffected(affectSpell.SpellFamilyName, mod.mask); + // TEMP: dont use IsAffected - !familyName and !familyFlags are not valid options for spell mods + // TODO: investigate if the !familyName and !familyFlags conditions are even valid for all other (nonmod) uses of SpellInfo::IsAffected + return affectSpell.SpellFamilyName == SpellFamilyName && mod.mask & SpellFamilyFlags; } public bool CanPierceImmuneAura(SpellInfo auraSpellInfo)