Core/Players: Load faction change items from db2 instead of db

Port From (https://github.com/TrinityCore/TrinityCore/commit/7b11d17f4928d17637ad8182f9c632d90f873db4)
2021-11-23 22:24:04 -05:00
parent 919d547ceb
commit cb74ab8075
6 changed files with 20 additions and 26 deletions
@@ -1997,14 +1997,15 @@ namespace Game
                    }

                    // Item conversion
-                    foreach (var it in Global.ObjectMgr.FactionChangeItems)
+                    var itemConversionMap = newTeamId == TeamId.Alliance ? Global.ObjectMgr.FactionChangeItemsHordeToAlliance : Global.ObjectMgr.FactionChangeItemsAllianceToHorde;
+                    foreach (var it in itemConversionMap)
                    {
-                        uint item_alliance = it.Key;
-                        uint item_horde = it.Value;
+                        uint oldItemId = it.Key;
+                        uint newItemId = it.Value;

                        stmt = DB.Characters.GetPreparedStatement(CharStatements.UPD_CHAR_INVENTORY_FACTION_CHANGE);
-                        stmt.AddValue(0, (newTeamId == TeamId.Alliance ? item_alliance : item_horde));
-                        stmt.AddValue(1, (newTeamId == TeamId.Alliance ? item_horde : item_alliance));
+                        stmt.AddValue(0, newItemId);
+                        stmt.AddValue(1, oldItemId);
                        stmt.AddValue(2, lowGuid);
                        trans.Append(stmt);
                    }