Core/Misc: Fix various crashes, also related to multithreading

Port From (https://github.com/TrinityCore/TrinityCore/commit/ad008c43b75080ec59aa973f1e2e4424332c34a4)
2019-08-16 22:03:02 -04:00
parent 653a9bb035
commit d3bce6a75c
19 changed files with 174 additions and 117 deletions
@@ -1525,6 +1525,10 @@ namespace Game.Entities
                        stmt.AddValue(2, GetGUID().GetCounter());
                        trans.Append(stmt);

+                        RemoveTradeableItem(item);
+                        RemoveEnchantmentDurationsReferences(item);
+                        RemoveItemDurations(item);
+
                        // also THIS item should be somewhere else, cheat attempt
                        item.FSetState(ItemUpdateState.Removed); // we are IN updateQueue right now, can't use SetState which modifies the queue
                        DeleteRefundReference(item.GetGUID());