Inna/CypherCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Core/SAI: Change error to warning for unused parameters

Browse Source 
Port From (https://github.com/TrinityCore/TrinityCore/commit/a19c71a77075b569192eca556635dba85ac6f2ec)
This commit is contained in:
hondacrx
2022-05-29 20:59:55 -04:00
parent f7130656aa
commit d6c9594c20
1 changed files with 6 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/Game/AI/SmartScripts/SmartAIManager.cs
+6 -17
View File
@@ -649,7 +649,6 @@ namespace Game.AI
int rawCount = Marshal.SizeOf(typeof(SmartEvent.Raw)) / sizeof(uint); int rawCount = Marshal.SizeOf(typeof(SmartEvent.Raw)) / sizeof(uint);
int paramsCount = paramsStructSize / sizeof(uint); int paramsCount = paramsStructSize / sizeof(uint);
bool valid = true;
for (int index = paramsCount; index < rawCount; index++) for (int index = paramsCount; index < rawCount; index++)
{ {
uint value = 0; uint value = 0;
@@ -673,13 +672,10 @@ namespace Game.AI
} }
if (value != 0) if (value != 0)
{ Log.outWarn(LogFilter.Sql, $"SmartAIMgr: {e} has unused event_param{index + 1} with value {value}, it should be 0.");
Log.outError(LogFilter.Sql, $"SmartAIMgr: {e} has unused event_param{index + 1} with value {value}, it must be 0, skipped.");
valid = false;
}
} }
return valid; return true;
} }
static bool CheckUnusedActionParams(SmartScriptHolder e) static bool CheckUnusedActionParams(SmartScriptHolder e)
@@ -840,7 +836,6 @@ namespace Game.AI
int rawCount = Marshal.SizeOf(typeof(SmartAction.Raw)) / sizeof(uint); int rawCount = Marshal.SizeOf(typeof(SmartAction.Raw)) / sizeof(uint);
int paramsCount = paramsStructSize / sizeof(uint); int paramsCount = paramsStructSize / sizeof(uint);
bool valid = true;
for (int index = paramsCount; index < rawCount; index++) for (int index = paramsCount; index < rawCount; index++)
{ {
uint value = 0; uint value = 0;
@@ -867,13 +862,10 @@ namespace Game.AI
} }
if (value != 0) if (value != 0)
{ Log.outWarn(LogFilter.Sql, $"SmartAIMgr: {e} has unused action_param{index + 1} with value {value}, it should be 0.");
Log.outError(LogFilter.Sql, $"SmartAIMgr: {e} has unused action_param{index + 1} with value {value}, it must be 0, skipped.");
valid = false;
}
} }
return valid; return true;
} }
static bool CheckUnusedTargetParams(SmartScriptHolder e) static bool CheckUnusedTargetParams(SmartScriptHolder e)
@@ -917,7 +909,6 @@ namespace Game.AI
int rawCount = Marshal.SizeOf(typeof(SmartTarget.Raw)) / sizeof(uint); int rawCount = Marshal.SizeOf(typeof(SmartTarget.Raw)) / sizeof(uint);
int paramsCount = paramsStructSize / sizeof(uint); int paramsCount = paramsStructSize / sizeof(uint);
bool valid = true;
for (int index = paramsCount; index < rawCount; index++) for (int index = paramsCount; index < rawCount; index++)
{ {
uint value = 0; uint value = 0;
@@ -936,11 +927,9 @@ namespace Game.AI
value = e.Target.raw.param4; value = e.Target.raw.param4;
break; break;
} }
if (value != 0) if (value != 0)
{ Log.outWarn(LogFilter.Sql, $"SmartAIMgr: {e} has unused target_param{index + 1} with value {value}, it must be 0, skipped.");
Log.outError(LogFilter.Sql, $"SmartAIMgr: {e} has unused target_param{index + 1} with value {value}, it must be 0, skipped.");
valid = false;
}
} }
return valid; return valid;