Core/Realms: Realmlist refactors

* Removed global realm variable from World and use RealmList everywhere * Match auth build key with client version * Restored allowedSecurityLevel checks for realmlist packet building * Restored updating population field Port From (https://github.com/TrinityCore/TrinityCore/commit/c4b710446d62c95eb8124175203fa5f394912594)
2024-09-26 12:53:15 -04:00
parent 8341244e4d
commit d70529bc19
36 changed files with 393 additions and 298 deletions
@@ -1439,7 +1439,10 @@ namespace Game.Achievements
                        return false;
                    break;
                case ModifierTreeType.ClientVersionEqualOrLessThan: // 33
-                    if (reqValue < Global.RealmMgr.GetMinorMajorBugfixVersionForBuild(Global.WorldMgr.GetRealm().Build))
+                    var currentRealm = Global.RealmMgr.GetCurrentRealm();
+                    if (currentRealm == null)
+                        return false;
+                    if (reqValue < Global.RealmMgr.GetMinorMajorBugfixVersionForBuild(currentRealm.Build))
                        return false;
                    break;
                case ModifierTreeType.BattlePetTeamLevel: // 34