Core/Gossip: Drop OptionType for gossip_menu_option and rename OptionIcon to OptionNpc as it also determines functionality on client side

Port From (https://github.com/TrinityCore/TrinityCore/commit/69e0249807f5a8f351e6be6f7350ebace3d2997a)
2022-09-08 18:06:18 -04:00
parent da1d0717fd
commit dbf746f9ea
13 changed files with 224 additions and 209 deletions
@@ -60,7 +60,7 @@ namespace Game.Networking.Packets
            foreach (ClientGossipOptions options in GossipOptions)
            {
                _worldPacket.WriteInt32(options.ClientOption);
-                _worldPacket.WriteUInt8(options.OptionNPC);
+                _worldPacket.WriteUInt8((byte)options.OptionNPC);
                _worldPacket.WriteUInt8(options.OptionFlags);
                _worldPacket.WriteInt32(options.OptionCost);
                _worldPacket.WriteUInt32(options.OptionLanguage);
@@ -345,7 +345,7 @@ namespace Game.Networking.Packets
    public class ClientGossipOptions
    {
        public int ClientOption;
-        public byte OptionNPC;
+        public GossipOptionNpc OptionNPC;
        public byte OptionFlags;
        public int OptionCost;
        public uint OptionLanguage;