Inna/CypherCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Core/Networking: Fixes disconnect when trying to send packets larger then 0x400.

Browse Source
This commit is contained in:
hondacrx
2021-03-05 14:18:10 -05:00
parent c79f91521e
commit eca32de055
3 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/Game/Networking/WorldSocket.cs
+8 -7
View File
@@ -243,12 +243,6 @@ namespace Game.Networking
PacketHeader header = new PacketHeader();
header.Read(_headerBuffer.GetData());
if (!header.IsValidSize())
{
Log.outError(LogFilter.Network, $"WorldSocket.ReadHeaderHandler(): client {GetRemoteIpAddress()} sent malformed packet (size: {header.Size})");
return false;
}
_packetBuffer.Resize(header.Size);
return true;
}
@@ -277,6 +271,13 @@ namespace Game.Networking
PacketLog.Write(packet.GetData(), packet.GetOpcode(), GetRemoteIpAddress(), _connectType, true);
ClientOpcodes opcode = (ClientOpcodes)packet.GetOpcode();
if (opcode != ClientOpcodes.HotfixRequest && !header.IsValidSize())
{
Log.outError(LogFilter.Network, $"WorldSocket.ReadHeaderHandler(): client {GetRemoteIpAddress()} sent malformed packet (size: {header.Size})");
return ReadDataHandlerResult.Error;
}
switch (opcode)
{
case ClientOpcodes.Ping:
@@ -376,7 +377,7 @@ namespace Game.Networking
buffer.WriteUInt32(ZLib.adler32(0x9827D8F1, compressedData, compressedSize));
buffer.WriteBytes(compressedData, compressedSize);
packetSize = (ushort)(compressedSize + 12);
packetSize = (int)(compressedSize + 12);
opcode = ServerOpcodes.CompressedPacket;
data = buffer.GetData();