Core/Movement: Add some extra assertions to MotionMaster.

Port From (https://github.com/TrinityCore/TrinityCore/commit/792914fb518349ef270e6f769f343bbcd333b942)
2021-11-15 22:12:20 -05:00
parent 81193e3e3a
commit ee8228582b
3 changed files with 8 additions and 4 deletions
@@ -884,7 +884,8 @@ namespace Game.Movement
                    Log.outDebug(LogFilter.Server, $"MotionMaster::MoveTaxiFlight: {_owner.GetGUID()} taxi to Path Id: {path} (node {pathnode})");

                    // Only one FLIGHT_MOTION_TYPE is allowed
-                    Remove(MovementGeneratorType.Flight);
+                    bool hasExisting = HasMovementGenerator(gen => gen.GetMovementGeneratorType() == MovementGeneratorType.Flight);
+                    Cypher.Assert(!hasExisting, "Duplicate flight path movement generator");

                    FlightPathMovementGenerator movement = new();
                    movement.LoadPath(_owner.ToPlayer());