Core/World: Refactor World::LoadConfigSettings to unify validation of all config options and reduce its impact on compile time

Port From (https://github.com/TrinityCore/TrinityCore/commit/b6d64447ba3a9aa4e3759e2c3582b07438da8633)
2025-09-04 22:30:57 -04:00
parent 9f05b762ad
commit f5906bce10
8 changed files with 580 additions and 1024 deletions
@@ -109,7 +109,7 @@ namespace Game

                    charResult.MaxCharacterLevel = Math.Max(charResult.MaxCharacterLevel, charInfo.ExperienceLevel);
                }
-                while (result.NextRow() && charResult.Characters.Count < 200);
+                while (result.NextRow() && charResult.Characters.Count < SharedConst.MaxCharactersPerRealm);
            }

            foreach (var requirement in Global.ObjectMgr.GetRaceUnlockRequirements())
@@ -893,6 +893,10 @@ namespace Game
                            break;
                    }
                }
+
+                // send new char string if not empty
+                if (!Global.WorldMgr.GetNewCharString().IsEmpty())
+                    pCurrChar.SendSysMessage(Global.WorldMgr.GetNewCharString());
            }

            if (!pCurrChar.GetMap().AddPlayerToMap(pCurrChar))