Inna/CypherCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Core/Auras: periodics refactor part 3: move more switch hacks to scripts

Browse Source 
Port From (https://github.com/TrinityCore/TrinityCore/commit/97e869e8b36afd9e7f0452b9001287f6b4a02ef2)
This commit is contained in:
hondacrx
2021-03-17 16:26:34 -04:00
parent 8556495e5e
commit ff36626d12
3 changed files with 91 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/Game/Spells/Auras/AuraEffect.cs
-34
View File
@@ -5246,40 +5246,6 @@ namespace Game.Spells
caster.SpellHitResult(target, GetSpellInfo(), false) != SpellMissInfo.None)
return;
// some auras remove at specific health level or more
if (GetAuraType() == AuraType.PeriodicDamage)
{
switch (GetSpellInfo().Id)
{
case 43093:
case 31956:
case 38801: // Grievous Wound
case 35321:
case 38363:
case 39215: // Gushing Wound
if (target.IsFullHealth())
{
target.RemoveAurasDueToSpell(GetSpellInfo().Id);
return;
}
break;
case 38772: // Grievous Wound
{
SpellEffectInfo effect = GetSpellInfo().GetEffect(1);
if (effect != null)
{
int percent = effect.CalcValue(caster);
if (!target.HealthBelowPct(percent))
{
target.RemoveAurasDueToSpell(GetSpellInfo().Id);
return;
}
}
break;
}
}
}
CleanDamage cleanDamage = new CleanDamage(0, 0, WeaponAttackType.BaseAttack, MeleeHitOutcome.Normal);
// AOE spells are not affected by the new periodic system.
Source/Scripts/Spells/Generic.cs
+71
View File
@@ -2076,6 +2076,77 @@ namespace Scripts.Spells.Generic
}
}
// 38772 Grievous Wound
// 43937 Grievous Wound
// 62331 Impale
[Script] // 62418 Impale
class spell_gen_remove_on_health_pct : AuraScript
{
void PeriodicTick(AuraEffect aurEff)
{
// they apply damage so no need to check for ticks here
if (GetTarget().HealthAbovePct(GetSpellInfo().GetEffect(1).CalcValue()))
{
Remove(AuraRemoveMode.EnemySpell);
PreventDefaultAction();
}
}
public override void Register()
{
OnEffectPeriodic.Add(new EffectPeriodicHandler(PeriodicTick, 0, AuraType.PeriodicDamage));
}
}
// 31956 Grievous Wound
// 38801 Grievous Wound
// 43093 Grievous Throw
// 58517 Grievous Wound
[Script] // 59262 Grievous Wound
class spell_gen_remove_on_full_health : AuraScript
{
void PeriodicTick(AuraEffect aurEff)
{
// if it has only periodic effect, allow 1 tick
bool onlyEffect = GetSpellInfo().GetEffects().Length == 1;
if (onlyEffect && aurEff.GetTickNumber() <= 1)
return;
if (GetTarget().IsFullHealth())
{
Remove(AuraRemoveMode.EnemySpell);
PreventDefaultAction();
}
}
public override void Register()
{
OnEffectPeriodic .Add(new EffectPeriodicHandler(PeriodicTick, 0, AuraType.PeriodicDamage));
}
}
// 70292 - Glacial Strike
[Script] // 71316 - Glacial Strike
class spell_gen_remove_on_full_health_pct : AuraScript
{
void PeriodicTick(AuraEffect aurEff)
{
// they apply damage so no need to check for ticks here
if (GetTarget().IsFullHealth())
{
Remove(AuraRemoveMode.EnemySpell);
PreventDefaultAction();
}
}
public override void Register()
{
OnEffectPeriodic .Add(new EffectPeriodicHandler(PeriodicTick, 2, AuraType.PeriodicDamagePercent));
}
}
[Script]
class spell_gen_replenishment : SpellScript
{