Core/Gossip: Remove gossip menu option fallback code, all menus are now required to have options defined instead of trying to get them from menuid = 0

Port From (https://github.com/TrinityCore/TrinityCore/commit/49709e427360006186744ca52116f9ee35092b83)
2022-10-11 19:55:30 -04:00
parent e5c7244893
commit 006d47a955
3 changed files with 26 additions and 30 deletions
@@ -654,11 +654,11 @@ namespace Game
        bool AddToGossipMenuItems(Condition cond)
        {
            var pMenuItemBounds = Global.ObjectMgr.GetGossipMenuItemsMapBounds(cond.SourceGroup);
-            foreach (var menuItems in pMenuItemBounds)
+            foreach (var gossipMenuItem in pMenuItemBounds)
            {
-                if (menuItems.MenuId == cond.SourceGroup && menuItems.OptionId == cond.SourceEntry)
+                if (gossipMenuItem.MenuId == cond.SourceGroup && gossipMenuItem.OptionId == cond.SourceEntry)
                {
-                    menuItems.Conditions.Add(cond);
+                    gossipMenuItem.Conditions.Add(cond);
                    return true;
                }
            }