Misc fixes

Source/Game/Handlers/ArtifactHandler.cs

@@ -50,16 +50,16 @@ namespace Game
             uint maxRank = artifactPowerEntry.MaxPurchasableRank;
             if (artifactPowerEntry.Tier < currentArtifactTier)
             {
-                if (artifactPowerEntry.Flags.HasAnyFlag(ArtifactPowerFlag.Final))
+                if (artifactPowerEntry.HasFlag(ArtifactPowerFlag.Final))
                     maxRank = 1;
-                else if (artifactPowerEntry.Flags.HasAnyFlag(ArtifactPowerFlag.MaxRankWithTier))
+                else if (artifactPowerEntry.HasFlag(ArtifactPowerFlag.MaxRankWithTier))
                     maxRank += currentArtifactTier - artifactPowerEntry.Tier;
             }
 
             if (artifactAddPower.PowerChoices[0].Rank != artifactPower.PurchasedRank + 1 ||
                 artifactAddPower.PowerChoices[0].Rank > maxRank)
                 return;
-            if (!artifactPowerEntry.Flags.HasAnyFlag(ArtifactPowerFlag.NoLinkRequired))
+            if (!artifactPowerEntry.HasFlag(ArtifactPowerFlag.NoLinkRequired))
             {
                 var artifactPowerLinks = Global.DB2Mgr.GetArtifactPowerLinks(artifactPower.ArtifactPowerId);
                 if (artifactPowerLinks != null)
@@ -100,7 +100,7 @@ namespace Game
                 foreach (ArtifactPower power in artifact.m_itemData.ArtifactPowers)
                 {
                     ArtifactPowerRecord scaledArtifactPowerEntry = CliDB.ArtifactPowerStorage.LookupByKey(power.ArtifactPowerId);
-                    if (!scaledArtifactPowerEntry.Flags.HasAnyFlag(ArtifactPowerFlag.ScalesWithNumPowers))
+                    if (!scaledArtifactPowerEntry.HasFlag(ArtifactPowerFlag.ScalesWithNumPowers))
                         continue;
 
                     ArtifactPowerRankRecord scaledArtifactPowerRank = Global.DB2Mgr.GetArtifactPowerRank(scaledArtifactPowerEntry.Id, 0);
@@ -122,7 +122,7 @@ namespace Game
 
             foreach (ArtifactTierRecord tier in CliDB.ArtifactTierStorage.Values)
             {
-                if (artifactPowerEntry.Flags.HasAnyFlag(ArtifactPowerFlag.Final) && artifactPowerEntry.Tier < PlayerConst.MaxArtifactTier)
+                if (artifactPowerEntry.HasFlag(ArtifactPowerFlag.Final) && artifactPowerEntry.Tier < PlayerConst.MaxArtifactTier)
                 {
                     artifactTier = artifactPowerEntry.Tier + 1u;
                     break;
@@ -234,7 +234,7 @@ namespace Game
             foreach (ArtifactPower power in artifact.m_itemData.ArtifactPowers)
             {
                 ArtifactPowerRecord scaledArtifactPowerEntry = CliDB.ArtifactPowerStorage.LookupByKey(power.ArtifactPowerId);
-                if (!scaledArtifactPowerEntry.Flags.HasAnyFlag(ArtifactPowerFlag.ScalesWithNumPowers))
+                if (!scaledArtifactPowerEntry.HasFlag(ArtifactPowerFlag.ScalesWithNumPowers))
                     continue;
 
                 ArtifactPowerRankRecord scaledArtifactPowerRank = Global.DB2Mgr.GetArtifactPowerRank(scaledArtifactPowerEntry.Id, 0);

Source/Game/Handlers/BattleGroundHandler.cs

@@ -62,7 +62,7 @@ namespace Game
             }
 
             BattlemasterListRecord battlemasterListEntry = CliDB.BattlemasterListStorage.LookupByKey(bgQueueTypeId.BattlemasterListId);
-            if (Global.DisableMgr.IsDisabledFor(DisableType.Battleground, bgQueueTypeId.BattlemasterListId, null) || battlemasterListEntry.Flags.HasAnyFlag(BattlemasterListFlags.Disabled))
+            if (Global.DisableMgr.IsDisabledFor(DisableType.Battleground, bgQueueTypeId.BattlemasterListId, null) || battlemasterListEntry.HasFlag(BattlemasterListFlags.Disabled))
             {
                 GetPlayer().SendSysMessage(CypherStrings.BgDisabled);
                 return;
@@ -692,7 +692,7 @@ namespace Game
             }
 
             AreaTableRecord atEntry = CliDB.AreaTableStorage.LookupByKey(GetPlayer().GetAreaId());
-            if (atEntry == null || !atEntry.GetFlags().HasFlag(AreaFlags.AllowHearthAndRessurectFromArea))
+            if (atEntry == null || !atEntry.HasFlag(AreaFlags.AllowHearthAndRessurectFromArea))
                 return;
 
             GetPlayer().BuildPlayerRepop();

Source/Game/Handlers/CharacterHandler.cs

@@ -166,7 +166,7 @@ namespace Game
 
         public bool MeetsChrCustomizationReq(ChrCustomizationReqRecord req, Race race, Class playerClass, bool checkRequiredDependentChoices, List<ChrCustomizationChoice> selectedChoices)
         {
-            if (!req.GetFlags().HasFlag(ChrCustomizationReqFlag.HasRequirements))
+            if (!req.HasFlag(ChrCustomizationReqFlag.HasRequirements))
                 return true;
 
             if (req.ClassMask != 0 && (req.ClassMask & (1 << ((int)playerClass - 1))) == 0)
@@ -370,7 +370,7 @@ namespace Game
 
             if (!HasPermission(RBACPermissions.SkipCheckCharacterCreationRacemask))
             {
-                if (raceEntry.GetFlags().HasFlag(ChrRacesFlag.NPCOnly))
+                if (raceEntry.HasFlag(ChrRacesFlag.NPCOnly))
                 {
                     Log.outError(LogFilter.Network, $"Race ({charCreate.CreateInfo.RaceId}) was not playable but requested while creating new char for account (ID: {GetAccountId()}): wrong DBC files or cheater?");
                     SendCharCreate(ResponseCodes.CharCreateDisabled);
@@ -1629,7 +1629,7 @@ namespace Game
                     if (illusion == null)
                         return false;
 
-                    if (illusion.ItemVisual == 0 || !illusion.GetFlags().HasFlag(SpellItemEnchantmentFlags.AllowTransmog))
+                    if (illusion.ItemVisual == 0 || !illusion.HasFlag(SpellItemEnchantmentFlags.AllowTransmog))
                         return false;
 
                     PlayerConditionRecord condition = CliDB.PlayerConditionStorage.LookupByKey(illusion.TransmogUseConditionID);

Source/Game/Handlers/ChatHandler.cs

@@ -335,7 +335,7 @@ namespace Game
                     if (chn != null)
                     {
                         var chatChannel = CliDB.ChatChannelsStorage.LookupByKey(chn.GetChannelId());
-                        if (chatChannel != null && chatChannel.GetFlags().HasFlag(ChatChannelFlags.ReadOnly))
+                        if (chatChannel != null && chatChannel.HasFlag(ChatChannelFlags.ReadOnly))
                             return;
 
                         Global.ScriptMgr.OnPlayerChat(GetPlayer(), type, lang, msg, chn);

Source/Game/Handlers/MiscHandler.cs

@@ -624,7 +624,7 @@ namespace Game
                 return;
             }
 
-            if (!difficultyEntry.Flags.HasAnyFlag(DifficultyFlags.CanSelect))
+            if (!difficultyEntry.HasFlag(DifficultyFlags.CanSelect))
             {
                 Log.outDebug(LogFilter.Network, "WorldSession.HandleSetDungeonDifficulty: {0} sent unselectable instance mode {1}!",
                     GetPlayer().GetGUID().ToString(), difficultyEntry.Id);
@@ -683,14 +683,14 @@ namespace Game
                 return;
             }
 
-            if (!difficultyEntry.Flags.HasAnyFlag(DifficultyFlags.CanSelect))
+            if (!difficultyEntry.HasFlag(DifficultyFlags.CanSelect))
             {
                 Log.outDebug(LogFilter.Network, "WorldSession.HandleSetDungeonDifficulty: {0} sent unselectable instance mode {1}!",
                     GetPlayer().GetGUID().ToString(), difficultyEntry.Id);
                 return;
             }
 
-            if (((int)(difficultyEntry.Flags & DifficultyFlags.Legacy) != 0) != (setRaidDifficulty.Legacy != 0))
+            if (difficultyEntry.HasFlag(DifficultyFlags.Legacy) != (setRaidDifficulty.Legacy != 0))
             {
                 Log.outDebug(LogFilter.Network, "WorldSession.HandleSetDungeonDifficulty: {0} sent not matching legacy difficulty {1}!",
                     GetPlayer().GetGUID().ToString(), difficultyEntry.Id);

Source/Game/Handlers/MovementHandler.cs

@@ -763,7 +763,7 @@ namespace Game
                         if (!shouldTeleport)
                         {
                             var currentNode = flight.GetPath()[(int)flight.GetCurrentNode()];
-                            shouldTeleport = currentNode.Flags.HasFlag(TaxiPathNodeFlags.Teleport);
+                            shouldTeleport = currentNode.HasFlag(TaxiPathNodeFlags.Teleport);
                         }
 
                         if (shouldTeleport)

Source/Game/Handlers/SkillHandler.cs

@@ -98,7 +98,7 @@ namespace Game
         void HandleUnlearnSkill(UnlearnSkill packet)
         {
             SkillRaceClassInfoRecord rcEntry = Global.DB2Mgr.GetSkillRaceClassInfo(packet.SkillLine, GetPlayer().GetRace(), GetPlayer().GetClass());
-            if (rcEntry == null || !rcEntry.Flags.HasAnyFlag(SkillRaceClassInfoFlags.Unlearnable))
+            if (rcEntry == null || !rcEntry.HasFlag(SkillRaceClassInfoFlags.Unlearnable))
                 return;
 
             GetPlayer().SetSkill(packet.SkillLine, 0, 0, 0);

Source/Game/Handlers/TraitHandler.cs

@@ -58,7 +58,7 @@ namespace Game
                         return;
                     }
 
-                    if (traitTree.GetFlags().HasFlag(TraitTreeFlag.CannotRefund))
+                    if (traitTree.HasFlag(TraitTreeFlag.CannotRefund))
                     {
                         SendPacket(new TraitConfigCommitFailed(configId, 0, (int)TalentLearnResult.FailedCantRemoveTalent));
                         return;