Inna/CypherCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Some refactoring of code. and some cleanups

Browse Source
This commit is contained in:
hondacrx
2019-09-21 12:11:16 -04:00
parent 7c405230cc
commit 35c06c09fd
214 changed files with 1235 additions and 1341 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/Game/Achievements/AchievementManager.cs
+1 -1
View File
@@ -1048,7 +1048,7 @@ namespace Game.Achievements
public bool IsRealmCompleted(AchievementRecord achievement)
{
var time = _allCompletedAchievements.LookupByKey(achievement.Id);
if (time == default(DateTime))
if (time == default)
return false;
if (time == DateTime.MinValue)
Source/Game/Achievements/CriteriaHandler.cs
+4 -4
View File
@@ -171,7 +171,7 @@ namespace Game.Achievements
SetCriteriaProgress(criteria, miscValue1, referencePlayer, ProgressType.Highest);
break;
case CriteriaTypes.ReachLevel:
SetCriteriaProgress(criteria, referencePlayer.getLevel(), referencePlayer);
SetCriteriaProgress(criteria, referencePlayer.GetLevel(), referencePlayer);
break;
case CriteriaTypes.ReachSkillLevel:
uint skillvalue = referencePlayer.GetBaseSkillValue((SkillType)criteria.Entry.Asset);
@@ -220,7 +220,7 @@ namespace Game.Achievements
{
uint counter = 0;
var rewQuests = referencePlayer.getRewardedQuests();
var rewQuests = referencePlayer.GetRewardedQuests();
foreach (var id in rewQuests)
{
Quest quest = Global.ObjectMgr.GetQuestTemplate(id);
@@ -1334,7 +1334,7 @@ namespace Game.Achievements
return false;
break;
case CriteriaAdditionalCondition.SourceLevel: // 39
if (referencePlayer.getLevel() != reqValue)
if (referencePlayer.GetLevel() != reqValue)
return false;
break;
case CriteriaAdditionalCondition.TargetLevel: // 40
@@ -1515,7 +1515,7 @@ namespace Game.Achievements
}
if (obj == null)
return default(T);
return default;
return obj;
}