Core/Achievement: correctly credit progress for skill-related achievements when learning a new skill.

Port From (https://github.com/TrinityCore/TrinityCore/commit/3264ef1f75af2430301050df3831e20c51ecf512)
2021-12-07 14:21:03 -05:00
parent 4fb48f1522
commit 7af628bccc
1 changed files with 2 additions and 3 deletions
@@ -1205,9 +1205,6 @@ namespace Game.Entities

                if (newVal != 0)
                {
-                    UpdateCriteria(CriteriaType.SkillRaised, id);
-                    UpdateCriteria(CriteriaType.AchieveSkillStep, id);
-
                    // temporary bonuses
                    foreach (var auraEffect in GetAuraEffectsByType(AuraType.ModSkill))
                        if (auraEffect.GetMiscValue() == id)
@@ -1224,6 +1221,8 @@ namespace Game.Entities

                    // Learn all spells for skill
                    LearnSkillRewardedSpells(id, newVal);
+                    UpdateCriteria(CriteriaType.SkillRaised, id);
+                    UpdateCriteria(CriteriaType.AchieveSkillStep, id);
                }
            }
        }