Core/Achievement: correctly credit progress for skill-related achievements when learning a new skill.
Port From (https://github.com/TrinityCore/TrinityCore/commit/3264ef1f75af2430301050df3831e20c51ecf512)
This commit is contained in:
@@ -1205,9 +1205,6 @@ namespace Game.Entities
|
|||||||
|
|
||||||
if (newVal != 0)
|
if (newVal != 0)
|
||||||
{
|
{
|
||||||
UpdateCriteria(CriteriaType.SkillRaised, id);
|
|
||||||
UpdateCriteria(CriteriaType.AchieveSkillStep, id);
|
|
||||||
|
|
||||||
// temporary bonuses
|
// temporary bonuses
|
||||||
foreach (var auraEffect in GetAuraEffectsByType(AuraType.ModSkill))
|
foreach (var auraEffect in GetAuraEffectsByType(AuraType.ModSkill))
|
||||||
if (auraEffect.GetMiscValue() == id)
|
if (auraEffect.GetMiscValue() == id)
|
||||||
@@ -1224,6 +1221,8 @@ namespace Game.Entities
|
|||||||
|
|
||||||
// Learn all spells for skill
|
// Learn all spells for skill
|
||||||
LearnSkillRewardedSpells(id, newVal);
|
LearnSkillRewardedSpells(id, newVal);
|
||||||
|
UpdateCriteria(CriteriaType.SkillRaised, id);
|
||||||
|
UpdateCriteria(CriteriaType.AchieveSkillStep, id);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user