Core/Quests: Use a helper function for quest objective StorageIndex startup validation
Port From (https://github.com/TrinityCore/TrinityCore/commit/5df1c6dea68efcbb5c739f459c7cbbda4d6984b5)
This commit is contained in:
@@ -7659,24 +7659,8 @@ namespace Game
|
||||
_questObjectives[obj.Id] = obj;
|
||||
|
||||
// Check storage index for objectives which store data
|
||||
if (obj.StorageIndex < 0)
|
||||
{
|
||||
switch (obj.Type)
|
||||
{
|
||||
case QuestObjectiveType.Monster:
|
||||
case QuestObjectiveType.Item:
|
||||
case QuestObjectiveType.GameObject:
|
||||
case QuestObjectiveType.TalkTo:
|
||||
case QuestObjectiveType.PlayerKills:
|
||||
case QuestObjectiveType.AreaTrigger:
|
||||
case QuestObjectiveType.WinPetBattleAgainstNpc:
|
||||
case QuestObjectiveType.ObtainCurrency:
|
||||
Log.outError(LogFilter.Sql, "Quest {0} objective {1} has invalid StorageIndex = {2} for objective type {3}", qinfo.Id, obj.Id, obj.StorageIndex, obj.Type);
|
||||
break;
|
||||
default:
|
||||
break;
|
||||
}
|
||||
}
|
||||
if (obj.IsStoringValue() && obj.StorageIndex < 0)
|
||||
Log.outError(LogFilter.Sql, $"Quest {qinfo.Id} objective {obj.Id} has invalid StorageIndex = {obj.StorageIndex} for objective type {obj.Type}");
|
||||
|
||||
switch (obj.Type)
|
||||
{
|
||||
|
||||
Reference in New Issue
Block a user