Inna/CypherCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Core/Spells: Avoid static analysis false positive

Browse Source 
Port From (https://github.com/TrinityCore/TrinityCore/commit/add2e6d212b356347241bfd1b52b37a447df74ce)
This commit is contained in:
hondacrx
2021-09-08 23:31:13 -04:00
parent 7cfe3c0021
commit b530251d6c
1 changed files with 8 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/Game/Spells/Spell.cs
+4 -16
View File
@@ -3624,30 +3624,19 @@ namespace Game.Spells
{ {
castData.RemainingRunes.HasValue = true; castData.RemainingRunes.HasValue = true;
RuneData runeData = castData.RemainingRunes.Value; RuneData runeData = castData.RemainingRunes.Value;
//TODO: There is a crash caused by a spell with CAST_FLAG_RUNE_LIST casted by a creature
//The creature is the mover of a player, so HandleCastSpellOpcode uses it as the caster
Player player = m_caster.ToPlayer(); Player player = m_caster.ToPlayer();
if (player)
{
runeData.Start = m_runesState; // runes state before runeData.Start = m_runesState; // runes state before
runeData.Count = player.GetRunesState(); // runes state after runeData.Count = player.GetRunesState(); // runes state after
for (byte i = 0; i < player.GetMaxPower(PowerType.Runes); ++i) for (byte i = 0; i < player.GetMaxPower(PowerType.Runes); ++i)
{ {
// float casts ensure the division is performed on floats as we need float result // float casts ensure the division is performed on floats as we need float result
float baseCd = player.GetRuneBaseCooldown(); float baseCd = (float)player.GetRuneBaseCooldown();
runeData.Cooldowns.Add((byte)((baseCd - player.GetRuneCooldown(i)) / baseCd * 255)); // rune cooldown passed runeData.Cooldowns.Add((byte)((baseCd - (float)player.GetRuneCooldown(i)) / baseCd * 255)); // rune cooldown passed
}
}
else
{
runeData.Start = 0;
runeData.Count = 0;
for (byte i = 0; i < player.GetMaxPower(PowerType.Runes); ++i)
runeData.Cooldowns.Add(0);
} }
} }
if (Convert.ToBoolean(castFlags & SpellCastFlags.AdjustMissile)) if (castFlags.HasFlag(SpellCastFlags.AdjustMissile))
{ {
castData.MissileTrajectory.TravelTime = (uint)m_delayMoment; castData.MissileTrajectory.TravelTime = (uint)m_delayMoment;
castData.MissileTrajectory.Pitch = m_targets.GetPitch(); castData.MissileTrajectory.Pitch = m_targets.GetPitch();
@@ -3655,7 +3644,6 @@ namespace Game.Spells
packet.LogData.Initialize(this); packet.LogData.Initialize(this);
m_caster.SendCombatLogMessage(packet); m_caster.SendCombatLogMessage(packet);
} }