Inna/CypherCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Core/Quests: Optimize Player::HasQuestForGO

Browse Source 
Port From (https://github.com/TrinityCore/TrinityCore/commit/eb834272cb0c0a1b1bb102bcee1b2a18b27f862d)
This commit is contained in:
hondacrx
2021-12-07 17:03:53 -05:00
parent 7bb87b1a8e
commit c1fd2cef37
1 changed files with 10 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/Game/Entities/Player/Player.Quest.cs
+10 -26
View File
@@ -2882,38 +2882,22 @@ namespace Game.Entities
public bool HasQuestForGO(int GOId) public bool HasQuestForGO(int GOId)
{ {
for (byte i = 0; i < SharedConst.MaxQuestLogSize; ++i) foreach (var objectiveStatusData in m_questObjectiveStatus.LookupByKey((QuestObjectiveType.GameObject, GOId)))
{ {
uint questid = GetQuestSlotQuestId(i); Quest qInfo = Global.ObjectMgr.GetQuestTemplate(objectiveStatusData.QuestStatusPair.QuestID);
if (questid == 0) QuestObjective objective = objectiveStatusData.Objective;
if (!IsQuestObjectiveCompletable(objectiveStatusData.QuestStatusPair.Status.Slot, qInfo, objective))
continue; continue;
var qs = m_QuestStatus.LookupByKey(questid); // hide quest if player is in raid-group and quest is no raid quest
if (qs == null) if (GetGroup() && GetGroup().IsRaidGroup() && !qInfo.IsAllowedInRaid(GetMap().GetDifficultyID()))
continue; if (!InBattleground()) //there are two ways.. we can make every bg-quest a raidquest, or add this code here.. i don't know if this can be exploited by other quests, but i think all other quests depend on a specific area.. but keep this in mind, if something strange happens later
if (qs.Status == QuestStatus.Incomplete)
{
Quest qInfo = Global.ObjectMgr.GetQuestTemplate(questid);
if (qInfo == null)
continue; continue;
if (GetGroup() != null && GetGroup().IsRaidGroup() && !qInfo.IsAllowedInRaid(GetMap().GetDifficultyID())) if (!IsQuestObjectiveComplete(objectiveStatusData.QuestStatusPair.Status.Slot, qInfo, objective))
continue; return true;
foreach (QuestObjective obj in qInfo.Objectives)
{
if (obj.Type != QuestObjectiveType.GameObject) //skip non GO case
continue;
if (!IsQuestObjectiveCompletable(i, qInfo, obj))
continue;
if (GOId == obj.ObjectID && GetQuestSlotObjectiveData(i, obj) < obj.Amount)
return true;
}
}
} }
return false; return false;
} }