Misc cleanups

This commit is contained in:
hondacrx
2021-02-09 13:13:08 -05:00
parent 759e13f6e2
commit e04769852a
3 changed files with 4 additions and 8 deletions
@@ -160,7 +160,7 @@ namespace Game.BattleGrounds.Zones
if (team == TeamId.Alliance) if (team == TeamId.Alliance)
UpdateWorldState(ABWorldStates.ResourcesAlly, m_TeamScores[team]); UpdateWorldState(ABWorldStates.ResourcesAlly, m_TeamScores[team]);
else if (team == TeamId.Horde) else
UpdateWorldState(ABWorldStates.ResourcesHorde, m_TeamScores[team]); UpdateWorldState(ABWorldStates.ResourcesHorde, m_TeamScores[team]);
// update achievement flags // update achievement flags
// we increased m_TeamScores[team] so we just need to check if it is 500 more than other teams resources // we increased m_TeamScores[team] so we just need to check if it is 500 more than other teams resources
@@ -387,12 +387,12 @@ namespace Game.BattleGrounds.Zones
void _NodeDeOccupied(byte node) void _NodeDeOccupied(byte node)
{ {
//only dynamic nodes, no start points
if (node >= ABBattlegroundNodes.DynamicNodesCount) if (node >= ABBattlegroundNodes.DynamicNodesCount)
return; return;
//remove bonus honor aura trigger creature when node is lost //remove bonus honor aura trigger creature when node is lost
if (node < ABBattlegroundNodes.DynamicNodesCount)//only dynamic nodes, no start points DelCreature(node + 7);//null checks are in DelCreature! 0-6 spirit guides
DelCreature(node + 7);//null checks are in DelCreature! 0-6 spirit guides
RelocateDeadPlayers(BgCreatures[node]); RelocateDeadPlayers(BgCreatures[node]);
+1 -1
View File
@@ -7598,7 +7598,7 @@ namespace Game
if (reverseMap != null) if (reverseMap != null)
reverseMap.Add(quest, id); reverseMap.Add(quest, id);
} }
else if (starter) else
poolRelationMap.Add(quest, id); poolRelationMap.Add(quest, id);
++count; ++count;
-4
View File
@@ -2203,11 +2203,7 @@ namespace Game.Spells
if (player == null) if (player == null)
return; return;
if (itemTarget == null)
return;
uint enchant_id = (uint)effectInfo.MiscValue; uint enchant_id = (uint)effectInfo.MiscValue;
if (enchant_id == 0) if (enchant_id == 0)
{ {
Log.outError(LogFilter.Spells, "Spell {0} Effect {1} (SPELL_EFFECT_ENCHANT_ITEM_TEMPORARY) have 0 as enchanting id", m_spellInfo.Id, effIndex); Log.outError(LogFilter.Spells, "Spell {0} Effect {1} (SPELL_EFFECT_ENCHANT_ITEM_TEMPORARY) have 0 as enchanting id", m_spellInfo.Id, effIndex);