Inna/CypherCore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Core/Spell: unified handling of SPELL_ATTR5_USABLE_WHILE_* attributes

Browse Source 
Port TrinityCore Commit: https://github.com/TrinityCore/TrinityCore/commit/2b0c73960b431acb25ddfba916017fbfe84f065b
This commit is contained in:
hondacrx
2019-08-14 12:05:26 -04:00
parent e35ba6d97f
commit ed3a310756
2 changed files with 113 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/Game/Spells/Spell.cs
+80 -29
View File
@@ -5388,8 +5388,16 @@ namespace Game.Spells
if (m_spellInfo.HasAttribute(SpellAttr6.IgnoreCasterAuras))
return SpellCastResult.SpellCastOk;
// these attributes only show the spell as usable on the client when it has related aura applied
// still they need to be checked against certain mechanics
// SPELL_ATTR5_USABLE_WHILE_STUNNED by default only MECHANIC_STUN (ie no sleep, knockout, freeze, etc.)
bool usableWhileStunned = m_spellInfo.HasAttribute(SpellAttr5.UsableWhileStunned);
// SPELL_ATTR5_USABLE_WHILE_FEARED by default only fear (ie no horror)
bool usableWhileFeared = m_spellInfo.HasAttribute(SpellAttr5.UsableWhileFeared);
// SPELL_ATTR5_USABLE_WHILE_CONFUSED by default only disorient (ie no polymorph)
bool usableWhileConfused = m_spellInfo.HasAttribute(SpellAttr5.UsableWhileConfused);
// Check whether the cast should be prevented by any state you might have.
@@ -5407,35 +5415,54 @@ namespace Game.Spells
result = SpellCastResult.Charmed;
}*/
// spell has attribute usable while having a cc state, check if caster has allowed mechanic auras, another mechanic types must prevent cast spell
SpellCastResult mechanicCheck(AuraType auraType, ref uint _param1)
{
bool foundNotMechanic = false;
var auras = m_caster.GetAuraEffectsByType(auraType);
foreach (AuraEffect aurEff in auras)
{
uint mechanicMask = aurEff.GetSpellInfo().GetAllEffectsMechanicMask();
if (mechanicMask != 0 && !Convert.ToBoolean(mechanicMask & GetSpellInfo().GetAllowedMechanicMask()))
{
foundNotMechanic = true;
// fill up aura mechanic info to send client proper error message
_param1 = (uint)aurEff.GetSpellInfo().GetEffect(aurEff.GetEffIndex()).Mechanic;
if (_param1 == 0)
_param1 = (uint)aurEff.GetSpellInfo().Mechanic;
break;
}
}
if (foundNotMechanic)
{
switch (auraType)
{
case AuraType.ModStun:
return SpellCastResult.Stunned;
case AuraType.ModFear:
return SpellCastResult.Fleeing;
case AuraType.ModConfuse:
return SpellCastResult.Confused;
default:
//ABORT();
return SpellCastResult.NotKnown;
}
}
return SpellCastResult.SpellCastOk;
}
if (unitflag.HasAnyFlag(UnitFlags.Stunned))
{
// spell is usable while stunned, check if caster has allowed stun auras, another stun types must prevent cast spell
if (usableWhileStunned)
{
uint allowedStunMask = 1 << (int)Mechanics.Stun | 1 << (int)Mechanics.Sleep;
bool foundNotStun = false;
var stunAuras = m_caster.GetAuraEffectsByType(AuraType.ModStun);
foreach (AuraEffect stunEff in stunAuras)
{
uint stunMechanicMask = stunEff.GetSpellInfo().GetAllEffectsMechanicMask();
if (stunMechanicMask != 0 && !Convert.ToBoolean(stunMechanicMask & allowedStunMask))
{
foundNotStun = true;
// fill up aura mechanic info to send client proper error message
param1 = (uint)stunEff.GetSpellInfo().GetEffect(stunEff.GetEffIndex()).Mechanic;
if (param1 == 0)
param1 = (uint)stunEff.GetSpellInfo().Mechanic;
break;
}
}
if (foundNotStun)
result = SpellCastResult.Stunned;
SpellCastResult mechanicResult = mechanicCheck(AuraType.ModStun, ref param1);
if (mechanicResult != SpellCastResult.SpellCastOk)
result = mechanicResult;
}
// Not usable while stunned, however spell might provide some immunity that allows to cast it anyway
else if (!CheckSpellCancelsStun(ref param1))
result = SpellCastResult.Stunned;
}
@@ -5443,16 +5470,35 @@ namespace Game.Spells
result = SpellCastResult.Silenced;
else if (unitflag.HasAnyFlag(UnitFlags.Pacified) && m_spellInfo.PreventionType.HasAnyFlag(SpellPreventionType.Pacify) && !CheckSpellCancelsPacify(ref param1))
result = SpellCastResult.Pacified;
else if (unitflag.HasAnyFlag(UnitFlags.Fleeing) && !usableWhileFeared && !CheckSpellCancelsFear(ref param1))
result = SpellCastResult.Fleeing;
else if (unitflag.HasAnyFlag(UnitFlags.Confused) && !usableWhileConfused && !CheckSpellCancelsConfuse(ref param1))
result = SpellCastResult.Confused;
else if (m_caster.HasUnitFlag2(UnitFlags2.NoActions) && m_spellInfo.PreventionType.HasAnyFlag(SpellPreventionType.NoActions))
else if (unitflag.HasAnyFlag(UnitFlags.Fleeing))
{
if (usableWhileFeared)
{
SpellCastResult mechanicResult = mechanicCheck(AuraType.ModFear, ref param1);
if (mechanicResult != SpellCastResult.SpellCastOk)
result = mechanicResult;
}
else if (!CheckSpellCancelsFear(ref param1))
result = SpellCastResult.Fleeing;
}
else if (unitflag.HasAnyFlag(UnitFlags.Confused))
{
if (usableWhileConfused)
{
SpellCastResult mechanicResult = mechanicCheck(AuraType.ModConfuse, ref param1);
if (mechanicResult != SpellCastResult.SpellCastOk)
result = mechanicResult;
}
else if (!CheckSpellCancelsConfuse(ref param1))
result = SpellCastResult.Confused;
}
else if (m_caster.HasUnitFlag2(UnitFlags2.NoActions) && m_spellInfo.PreventionType.HasAnyFlag(SpellPreventionType.NoActions) && !CheckSpellCancelsNoActions(ref param1))
result = SpellCastResult.NoActions;
// Attr must make flag drop spell totally immune from all effects
if (result != SpellCastResult.SpellCastOk)
return (param1 != 0) ? SpellCastResult.PreventedByMechanic : result;
return SpellCastResult.SpellCastOk;
}
@@ -5513,6 +5559,11 @@ namespace Game.Spells
return CheckSpellCancelsAuraEffect(AuraType.ModConfuse, ref param1);
}
bool CheckSpellCancelsNoActions(ref uint param1)
{
return CheckSpellCancelsAuraEffect(AuraType.ModNoActions, ref param1);
}
SpellCastResult CheckArenaAndRatedBattlegroundCastRules()
{
bool isRatedBattleground = false; // NYI
Source/Game/Spells/SpellInfo.cs
+33
View File
@@ -2371,6 +2371,8 @@ namespace Game.Spells
immuneInfo.MechanicImmuneMask = mechanicImmunityMask;
immuneInfo.DispelImmune = dispelImmunity;
immuneInfo.DamageSchoolMask = damageImmunityMask;
_allowedMechanicMask |= immuneInfo.MechanicImmuneMask;
});
foreach (var effects in _effects)
@@ -2383,6 +2385,31 @@ namespace Game.Spells
loadImmunityInfoFn(effect);
}
}
if (HasAttribute(SpellAttr5.UsableWhileStunned))
{
switch (Id)
{
case 22812: // Barkskin
_allowedMechanicMask |=
(1 << (int)Mechanics.Stun) |
(1 << (int)Mechanics.Freeze) |
(1 << (int)Mechanics.Knockout) |
(1 << (int)Mechanics.Sleep);
break;
case 49039: // Lichborne, don't allow normal stuns
break;
default:
_allowedMechanicMask |= (1 << (int)Mechanics.Stun);
break;
}
}
if (HasAttribute(SpellAttr5.UsableWhileConfused))
_allowedMechanicMask |= (1 << (int)Mechanics.Disoriented);
if (HasAttribute(SpellAttr5.UsableWhileFeared))
_allowedMechanicMask |= (1 << (int)Mechanics.Fear);
}
public void ApplyAllSpellImmunitiesTo(Unit target, SpellEffectInfo effect, bool apply)
@@ -2590,6 +2617,11 @@ namespace Game.Spells
return false;
}
public uint GetAllowedMechanicMask()
{
return _allowedMechanicMask;
}
public float GetMinRange(bool positive = false)
{
if (RangeEntry == null)
@@ -3733,6 +3765,7 @@ namespace Game.Spells
AuraStateType _auraState;
SpellDiminishInfo _diminishInfo;
uint _allowedMechanicMask;
#endregion
public struct ScalingInfo