Core/Pets: Fixed crash happening when summoning a different pet than one that was unsummoned by summoning a guardian (imp -> infernal -> felhunter)

Port From (https://github.com/TrinityCore/TrinityCore/commit/e102022eeb8a0fd402e34de92468b2afb8f1f006)
2022-03-10 09:46:47 -05:00
parent 9b2e317c44
commit f56aee73f0
1 changed files with 3 additions and 2 deletions
@@ -127,8 +127,9 @@ namespace Game.Entities
                        if (oldPet != minion && (oldPet.IsPet() || minion.IsPet() || oldPet.GetEntry() != minion.GetEntry()))
                        {
                            // remove existing minion pet
-                            if (oldPet.IsPet())
-                                ((Pet)oldPet).Remove(PetSaveMode.AsCurrent);
+                            Pet oldPetAsPet = oldPet.ToPet();
+                            if (oldPetAsPet != null)
+                                oldPetAsPet.Remove(PetSaveMode.NotInSlot);
                            else
                                oldPet.UnSummon();
                            SetPetGUID(minion.GetGUID());